Skip to content

Commit 688cb33

Browse files
committed
fix: r
Signed-off-by: Ashing Zheng <[email protected]>
1 parent 3e9ae07 commit 688cb33

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

test/e2e/gatewayapi/httproute.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2526,8 +2526,13 @@ spec:
25262526
},
25272527
}
25282528

2529-
conn, resp, err := dialer.Dial(u.String(), headers)
2530-
Expect(err).ShouldNot(HaveOccurred(), "WebSocket handshake")
2529+
var conn *websocket.Conn
2530+
var resp *http.Response
2531+
Eventually(func() error {
2532+
var dialErr error
2533+
conn, resp, dialErr = dialer.Dial(u.String(), headers)
2534+
return dialErr
2535+
}).WithTimeout(30*time.Second).WithPolling(2*time.Second).Should(Succeed(), "WebSocket handshake should succeed")
25312536
Expect(resp.StatusCode).Should(Equal(http.StatusSwitchingProtocols))
25322537

25332538
defer func() {
@@ -2536,7 +2541,7 @@ spec:
25362541

25372542
By("send and receive message through WebSocket")
25382543
testMessage := "hello, this is APISIX"
2539-
err = conn.WriteMessage(websocket.TextMessage, []byte(testMessage))
2544+
err := conn.WriteMessage(websocket.TextMessage, []byte(testMessage))
25402545
Expect(err).ShouldNot(HaveOccurred(), "writing WebSocket message")
25412546

25422547
// Then our echo

test/e2e/ingress/ingress.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1087,8 +1087,13 @@ spec:
10871087
},
10881088
}
10891089

1090-
conn, resp, err := dialer.Dial(u.String(), headers)
1091-
Expect(err).ShouldNot(HaveOccurred(), "WebSocket handshake")
1090+
var conn *websocket.Conn
1091+
var resp *http.Response
1092+
Eventually(func() error {
1093+
var dialErr error
1094+
conn, resp, dialErr = dialer.Dial(u.String(), headers)
1095+
return dialErr
1096+
}).WithTimeout(30*time.Second).WithPolling(2*time.Second).Should(Succeed(), "WebSocket handshake should succeed")
10921097
Expect(resp.StatusCode).Should(Equal(http.StatusSwitchingProtocols))
10931098

10941099
defer func() {
@@ -1097,7 +1102,7 @@ spec:
10971102

10981103
By("send and receive message through WebSocket")
10991104
testMessage := "hello, this is APISIX"
1100-
err = conn.WriteMessage(websocket.TextMessage, []byte(testMessage))
1105+
err := conn.WriteMessage(websocket.TextMessage, []byte(testMessage))
11011106
Expect(err).ShouldNot(HaveOccurred(), "writing WebSocket message")
11021107

11031108
// Then our echo

0 commit comments

Comments
 (0)