fix: http route

Signed-off-by: ashing <[email protected]>

Author: ronething

internal/provider/adc/adc.go

@@ -7,6 +7,7 @@ import (
 	"errors"
 	"os"
 	"os/exec"
+	"slices"
 	"sync"
 
 	"go.uber.org/zap"
@@ -147,36 +148,50 @@ func (d *adcClient) Update(ctx context.Context, tctx *provider.TranslateContext,
 		err           error
 	)
 
+	rk := ResourceKind{
+		Kind:      obj.GetObjectKind().GroupVersionKind().Kind,
+		Namespace: obj.GetNamespace(),
+		Name:      obj.GetName(),
+	}
 	switch t := obj.(type) {
 	case *gatewayv1.HTTPRoute:
-		result, err = d.translator.TranslateHTTPRoute(tctx, t.DeepCopy())
+		if result, err = d.translator.TranslateHTTPRoute(tctx, t.DeepCopy()); err != nil {
+			return err
+		}
 		resourceTypes = append(resourceTypes, "service")
+		// delete http route if old configs diff with new configs exist
+		if err = d.DeleteHTTPRoute(ctx, tctx, t.DeepCopy()); err != nil {
+			return err
+		}
 	case *gatewayv1.Gateway:
-		result, err = d.translator.TranslateGateway(tctx, t.DeepCopy())
+		if result, err = d.translator.TranslateGateway(tctx, t.DeepCopy()); err != nil {
+			return err
+		}
 		resourceTypes = append(resourceTypes, "global_rule", "ssl", "plugin_metadata")
+		if err = d.updateConfigs(rk, tctx); err != nil {
+			return err
+		}
 	case *networkingv1.Ingress:
-		result, err = d.translator.TranslateIngress(tctx, t.DeepCopy())
+		if result, err = d.translator.TranslateIngress(tctx, t.DeepCopy()); err != nil {
+			return err
+		}
 		resourceTypes = append(resourceTypes, "service", "ssl")
+		if err = d.updateConfigs(rk, tctx); err != nil {
+			return err
+		}
 	case *v1alpha1.Consumer:
-		result, err = d.translator.TranslateConsumerV1alpha1(tctx, t.DeepCopy())
+		if result, err = d.translator.TranslateConsumerV1alpha1(tctx, t.DeepCopy()); err != nil {
+			return err
+		}
 		resourceTypes = append(resourceTypes, "consumer")
-	}
-	if err != nil {
-		return err
+		if err = d.updateConfigs(rk, tctx); err != nil {
+			return err
+		}
 	}
 	if result == nil {
 		return nil
 	}
 
-	// update adc configs
-	rk := ResourceKind{
-		Kind:      obj.GetObjectKind().GroupVersionKind().Kind,
-		Namespace: obj.GetNamespace(),
-		Name:      obj.GetName(),
-	}
-	if err := d.updateConfigs(rk, tctx); err != nil {
-		return err
-	}
 	configs := d.getConfigs(rk)
 
 	return d.sync(Task{
@@ -194,6 +209,48 @@ func (d *adcClient) Update(ctx context.Context, tctx *provider.TranslateContext,
 	})
 }
 
+func (d *adcClient) DeleteHTTPRoute(ctx context.Context, tctx *provider.TranslateContext, obj client.Object) error {
+	// diff adc configs
+	rk := ResourceKind{
+		Kind:      obj.GetObjectKind().GroupVersionKind().Kind,
+		Namespace: obj.GetNamespace(),
+		Name:      obj.GetName(),
+	}
+
+	oldConfigs := d.getConfigs(rk)
+	err := d.updateConfigs(rk, tctx)
+	if err != nil {
+		return err
+	}
+	newConfigs := d.getConfigs(rk)
+
+	// diff old configs and new configs
+	var deleteConfigs []adcConfig
+	for _, config := range oldConfigs {
+		if !slices.ContainsFunc(newConfigs, func(c adcConfig) bool {
+			return c.ServerAddr == config.ServerAddr && c.Token == config.Token
+		}) {
+			deleteConfigs = append(deleteConfigs, config)
+		}
+	}
+
+	if len(deleteConfigs) > 0 {
+		log.Debugw("http route delete configs", zap.Any("configs", deleteConfigs))
+		// sync old delete
+		err = d.sync(Task{
+			Name:          obj.GetName(),
+			Labels:        label.GenLabel(obj),
+			ResourceTypes: []string{"service"},
+			configs:       deleteConfigs,
+		})
+		if err != nil {
+			return err
+		}
+	}
+
+	return nil
+}
+
 func (d *adcClient) Delete(ctx context.Context, obj client.Object) error {
 	log.Debugw("deleting object", zap.Any("object", obj))