Skip to content

Commit 78f02b0

Browse files
committed
fix: r
Signed-off-by: Ashing Zheng <[email protected]>
1 parent 6ea61f1 commit 78f02b0

File tree

4 files changed

+4
-18
lines changed

4 files changed

+4
-18
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ require (
2929
go.uber.org/zap v1.27.0
3030
golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56
3131
golang.org/x/net v0.28.0
32-
gopkg.in/yaml.v2 v2.4.0
3332
gopkg.in/yaml.v3 v3.0.1
3433
helm.sh/helm/v3 v3.15.4
3534
k8s.io/api v0.31.1
@@ -207,6 +206,7 @@ require (
207206
gopkg.in/fsnotify.v1 v1.4.7 // indirect
208207
gopkg.in/inf.v0 v0.9.1 // indirect
209208
gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 // indirect
209+
gopkg.in/yaml.v2 v2.4.0 // indirect
210210
k8s.io/apiserver v0.31.1 // indirect
211211
k8s.io/cli-runtime v0.30.3 // indirect
212212
k8s.io/component-base v0.31.1 // indirect

internal/controller/gatewayproxy_controller.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,18 +193,15 @@ func (r *GatewayProxyController) Reconcile(ctx context.Context, req ctrl.Request
193193
}
194194

195195
func (r *GatewayProxyController) listGatewayProxiesForProviderService(ctx context.Context, obj client.Object) (requests []reconcile.Request) {
196-
r.Log.Info("listGatewayProxiesForProviderService", "obj", obj.GetName())
197196
service, ok := obj.(*corev1.Service)
198197
if !ok {
199198
r.Log.Error(errors.New("unexpected object type"), "failed to convert object to Service")
200199
return nil
201200
}
202201

203-
requests = ListRequests(ctx, r.Client, r.Log, &v1alpha1.GatewayProxyList{}, client.MatchingFields{
202+
return ListRequests(ctx, r.Client, r.Log, &v1alpha1.GatewayProxyList{}, client.MatchingFields{
204203
indexer.ServiceIndexRef: indexer.GenIndexKey(service.GetNamespace(), service.GetName()),
205204
})
206-
r.Log.Info("listGatewayProxiesForProviderService", "requests", requests)
207-
return requests
208205
}
209206

210207
func (r *GatewayProxyController) listGatewayProxiesForProviderEndpointSlice(ctx context.Context, obj client.Object) (requests []reconcile.Request) {

test/e2e/gatewayapi/status.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import (
2424

2525
. "github.com/onsi/ginkgo/v2"
2626
. "github.com/onsi/gomega"
27-
"gopkg.in/yaml.v2"
27+
"gopkg.in/yaml.v3"
2828
corev1 "k8s.io/api/core/v1"
2929

3030
"github.com/apache/apisix-ingress-controller/internal/provider/adc"

test/e2e/scaffold/assertion.go

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -188,18 +188,7 @@ func (s *Scaffold) RequestAssert(r *RequestAssert) bool {
188188
if r.BasicAuth != nil {
189189
req = req.WithBasicAuth(r.BasicAuth.Username, r.BasicAuth.Password)
190190
}
191-
var err error
192-
expResp, err := func() (*httpexpect.Response, error) {
193-
defer func() {
194-
if rec := recover(); rec != nil {
195-
err = fmt.Errorf("panic in Expect(): %v", rec)
196-
}
197-
}()
198-
return req.Expect(), nil
199-
}()
200-
if err != nil {
201-
return err
202-
}
191+
expResp := req.Expect()
203192

204193
resp := &HTTPResponse{
205194
Response: expResp.Raw(),

0 commit comments

Comments
 (0)