Skip to content

Commit 86c5e6e

Browse files
AlinsRanronething
authored andcommitted
chore: upgrade adc to 0.21.0 (#2532)
Signed-off-by: Ashing Zheng <[email protected]>
1 parent 3879159 commit 86c5e6e

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

.github/workflows/apisix-conformance-test.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ jobs:
4040
provider_type:
4141
- apisix-standalone
4242
- apisix
43-
env:
44-
ADC_VERSION: "dev"
4543
runs-on: ubuntu-latest
4644
steps:
4745
- name: Checkout

.github/workflows/apisix-e2e-test.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ jobs:
4141
- networking.k8s.io
4242
fail-fast: false
4343
runs-on: ubuntu-latest
44-
env:
45-
ADC_VERSION: "dev"
4644
steps:
4745
- name: Checkout
4846
uses: actions/checkout@v4

Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ KIND_NODE_IMAGE ?= kindest/node:v1.30.0@sha256:047357ac0cfea04663786a612ba1eaba9
3131

3232
GATEAY_API_VERSION ?= v1.2.0
3333
DASHBOARD_VERSION ?= dev
34-
ADC_VERSION ?= 0.20.0
34+
ADC_VERSION ?= 0.21.0
3535

3636
GINKGO_VERSION ?= 2.20.0
3737
TEST_TIMEOUT ?= 80m
@@ -346,6 +346,9 @@ CONTROLLER_TOOLS_VERSION ?= v0.17.2
346346
ENVTEST_VERSION ?= release-0.18
347347
GOLANGCI_LINT_VERSION ?= v2.1.5
348348

349+
## export PATH so that the tools are found
350+
export PATH := $(LOCALBIN):$(PATH)
351+
349352
.PHONY: kustomize
350353
kustomize: $(KUSTOMIZE) ## Download kustomize locally if necessary.
351354
$(KUSTOMIZE): $(LOCALBIN)

test/e2e/scaffold/adc.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,21 @@ import (
3535
)
3636

3737
var (
38-
adcExec = "./bin/adc"
38+
adcExec = "adc"
3939
adcArgs []string
4040
)
4141

4242
func init() {
4343
adc := os.Getenv("ADC_BIN")
44-
if adc != "" && strings.Contains(adc, "node") {
44+
if adc == "" {
45+
return
46+
}
47+
if strings.Contains(adc, "node") {
4548
parts := strings.Fields(adc)
4649
adcExec = parts[0]
4750
adcArgs = parts[1:]
51+
} else {
52+
adcExec = adc
4853
}
4954
}
5055

0 commit comments

Comments
 (0)