fix test

Author: AlinsRan

internal/controller/apisixroute_controller.go

@@ -487,7 +487,13 @@ func (r *ApisixRouteReconciler) validateHTTPBackend(tctx *provider.TranslateCont
 	// backend.subset specifies a subset of upstream nodes.
 	// It specifies that the target pod's label should be a superset of the subset labels of the ApisixUpstream of the serviceName
 	subsetLabels := r.getSubsetLabels(tctx, serviceNN, backend.Subset)
-	tctx.EndpointSlices[serviceNN] = filterEndpointSlicesBySubsetLabels(tctx, r.Client, endpoints.Items, subsetLabels)
+
+	if err := resolveServiceEndpoints(tctx, r.Client, serviceNN, r.supportsEndpointSlice, subsetLabels); err != nil {
+		return types.ReasonError{
+			Reason:  string(apiv2.ConditionReasonInvalidSpec),
+			Message: err.Error(),
+		}
+	}
 
 	return nil
 }

internal/controller/gatewayproxy_controller.go

@@ -145,7 +145,7 @@ func (r *GatewayProxyController) Reconcile(ctx context.Context, req ctrl.Request
 			return reconcile.Result{}, err
 		}
 		tctx.Services[serviceNN] = service
-		if err := resolveServiceEndpoints(tctx, r.Client, tctx, serviceNN, r.supportsEndpointSlice, nil); err != nil {
+		if err := resolveServiceEndpoints(tctx, r.Client, serviceNN, r.supportsEndpointSlice, nil); err != nil {
 			return reconcile.Result{}, err
 		}
 	}

internal/controller/httproute_controller.go

@@ -571,7 +571,7 @@ func (r *HTTPRouteReconciler) processHTTPRouteBackendRefs(tctx *provider.Transla
 		tctx.Services[targetNN] = &service
 
 		// Collect endpoints with EndpointSlice support
-		if err := resolveServiceEndpoints(tctx, r.Client, tctx, targetNN, r.supportsEndpointSlice, nil); err != nil {
+		if err := resolveServiceEndpoints(tctx, r.Client, targetNN, r.supportsEndpointSlice, nil); err != nil {
 			r.Log.Error(err, "failed to collect endpoints", "Service", targetNN)
 			terr = err
 			continue

internal/controller/ingress_controller.go

@@ -594,7 +594,7 @@ func (r *IngressReconciler) processBackendService(tctx *provider.TranslateContex
 	}
 
 	// Collect endpoints with EndpointSlice support
-	if err := resolveServiceEndpoints(tctx, r.Client, tctx, serviceNS, r.supportsEndpointSlice, nil); err != nil {
+	if err := resolveServiceEndpoints(tctx, r.Client, serviceNS, r.supportsEndpointSlice, nil); err != nil {
 		r.Log.Error(err, "failed to collect endpoints", "namespace", namespace, "name", backendService.Name)
 		return err
 	}

internal/controller/utils.go

@@ -1499,7 +1499,7 @@ func addProviderEndpointsToTranslateContext(tctx *provider.TranslateContext, c c
 	}
 	tctx.Services[serviceNN] = &service
 
-	return resolveServiceEndpoints(tctx, c, tctx, serviceNN, true, nil)
+	return resolveServiceEndpoints(tctx, c, serviceNN, true, nil)
 }
 
 func TypePredicate[T client.Object]() func(obj client.Object) bool {
@@ -1556,16 +1556,15 @@ func watchEndpointSliceOrEndpoints(bdr *ctrl.Builder, supportsEndpointSlice bool
 // resolveServiceEndpoints collects endpoints and adds them to the translate context
 // It handles both EndpointSlice (K8s 1.19+) and Endpoints (K8s 1.18) APIs with automatic fallback
 func resolveServiceEndpoints(
-	ctx context.Context,
-	c client.Client,
 	tctx *provider.TranslateContext,
+	c client.Client,
 	serviceNN k8stypes.NamespacedName,
 	supportsEndpointSlice bool,
 	subsetLabels map[string]string,
 ) error {
 	if supportsEndpointSlice {
 		var endpoints discoveryv1.EndpointSliceList
-		if err := c.List(ctx, &endpoints,
+		if err := c.List(tctx, &endpoints,
 			client.InNamespace(serviceNN.Namespace),
 			client.MatchingLabels{
 				discoveryv1.LabelServiceName: serviceNN.Name,
@@ -1578,12 +1577,12 @@ func resolveServiceEndpoints(
 			tctx.EndpointSlices[serviceNN] = endpoints.Items
 		} else {
 			// Apply subset filtering
-			tctx.EndpointSlices[serviceNN] = filterEndpointSlicesBySubsetLabels(ctx, c, endpoints.Items, subsetLabels)
+			tctx.EndpointSlices[serviceNN] = filterEndpointSlicesBySubsetLabels(tctx, c, endpoints.Items, subsetLabels)
 		}
 	} else {
 		// Fallback to Endpoints API for Kubernetes 1.18 compatibility
 		var ep corev1.Endpoints
-		if err := c.Get(ctx, serviceNN, &ep); err != nil {
+		if err := c.Get(tctx, serviceNN, &ep); err != nil {
 			if client.IgnoreNotFound(err) != nil {
 				return fmt.Errorf("failed to get endpoints: %v", err)
 			}
@@ -1597,7 +1596,7 @@ func resolveServiceEndpoints(
 				tctx.EndpointSlices[serviceNN] = convertedEndpointSlices
 			} else {
 				// Apply subset filtering to converted EndpointSlices
-				tctx.EndpointSlices[serviceNN] = filterEndpointSlicesBySubsetLabels(ctx, c, convertedEndpointSlices, subsetLabels)
+				tctx.EndpointSlices[serviceNN] = filterEndpointSlicesBySubsetLabels(tctx, c, convertedEndpointSlices, subsetLabels)
 			}
 		}
 	}