Skip to content

Commit 9be7bee

Browse files
committed
fix test
1 parent 06ee3a7 commit 9be7bee

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

.github/workflows/apisix-e2e-test.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ jobs:
5353
ARCH: amd64
5454
ENABLE_PROXY: "false"
5555
BASE_IMAGE_TAG: "debug"
56+
ADC_VERSION: "dev"
5657
run: |
5758
echo "building images..."
5859
make build-image
@@ -67,5 +68,7 @@ jobs:
6768
6869
- name: Run E2E test suite
6970
shell: bash
71+
env:
72+
TEST_DIR: "test/e2e/apisix/"
7073
run: |
71-
make e2e-test-standalone
74+
make e2e-test

Makefile

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,14 @@ IMAGE_TAG ?= dev
88
IMG ?= api7/api7-ingress-controller:$(IMAGE_TAG)
99
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
1010
ENVTEST_K8S_VERSION = 1.30.0
11-
1211
KIND_NAME ?= apisix-ingress-cluster
13-
GATEAY_API_VERSION ?= v1.2.0
1412

13+
GATEAY_API_VERSION ?= v1.2.0
1514
DASHBOARD_VERSION ?= dev
15+
ADC_VERSION ?= 0.19.0
16+
1617
TEST_TIMEOUT ?= 60m
18+
TEST_DIR ?= ./test/e2e/
1719

1820
# CRD Reference Documentation
1921
CRD_REF_DOCS_VERSION ?= v0.1.0
@@ -109,12 +111,7 @@ kind-e2e-test: kind-up build-image kind-load-images e2e-test
109111
.PHONY: e2e-test
110112
e2e-test:
111113
@kind get kubeconfig --name $(KIND_NAME) > $$KUBECONFIG
112-
DASHBOARD_VERSION=$(DASHBOARD_VERSION) go test ./test/e2e/ -test.timeout=$(TEST_TIMEOUT) -v -ginkgo.v -ginkgo.focus="$(TEST_FOCUS)"
113-
114-
.PHONY: e2e-test-standalone
115-
e2e-test-standalone:
116-
@kind get kubeconfig --name $(KIND_NAME) > $$KUBECONFIG
117-
go test ./test/e2e/apisix/ -test.timeout=$(TEST_TIMEOUT) -v -ginkgo.v -ginkgo.focus="$(TEST_FOCUS)"
114+
DASHBOARD_VERSION=$(DASHBOARD_VERSION) go test $(TEST_DIR) -test.timeout=$(TEST_TIMEOUT) -v -ginkgo.v -ginkgo.focus="$(TEST_FOCUS)"
118115

119116
.PHONY: download-api7ee3-chart
120117
download-api7ee3-chart:
@@ -206,11 +203,11 @@ build-multi-arch:
206203
.PHONY: build-multi-arch-image
207204
build-multi-arch-image: build-multi-arch
208205
# daemon.json: "features":{"containerd-snapshotter": true}
209-
@docker buildx build --load --platform linux/amd64,linux/arm64 -t $(IMG) .
206+
@docker buildx build --load --platform linux/amd64,linux/arm64 --build-arg ADC_VERSION=$(ADC_VERSION) -t $(IMG) .
210207

211208
.PHONY: build-push-multi-arch-image
212209
build-push-multi-arch-image: build-multi-arch
213-
@docker buildx build --push --platform linux/amd64,linux/arm64 -t $(IMG) .
210+
@docker buildx build --push --platform linux/amd64,linux/arm64 --build-arg ADC_VERSION=$(ADC_VERSION) -t $(IMG) .
214211

215212
.PHONY: run
216213
run: manifests generate fmt vet ## Run a controller from your host.
@@ -221,7 +218,12 @@ run: manifests generate fmt vet ## Run a controller from your host.
221218
# More info: https://docs.docker.com/develop/develop-images/build_enhancements/
222219
.PHONY: docker-build
223220
docker-build: set-e2e-goos build ## Build docker image with the manager.
224-
$(CONTAINER_TOOL) build -t ${IMG} -f Dockerfile .
221+
@echo "Building with ADC_VERSION=$(ADC_VERSION)"
222+
@if [ "$(strip $(ADC_VERSION))" = "dev" ]; then \
223+
$(CONTAINER_TOOL) build -t ${IMG} -f Dockerfile.dev . ; \
224+
else \
225+
$(CONTAINER_TOOL) build --build-arg ADC_VERSION=${ADC_VERSION} -t ${IMG} -f Dockerfile . ; \
226+
fi
225227

226228
.PHONY: docker-push
227229
docker-push: ## Push docker image with the manager.

0 commit comments

Comments
 (0)