fix: r

Signed-off-by: ashing <[email protected]>

Author: ronething

internal/controller/utils.go

@@ -458,39 +458,51 @@ func HostnamesIntersect(a, b string) bool {
 	return HostnamesMatch(a, b) || HostnamesMatch(b, a)
 }
 
+// HostnamesMatch checks that the hostnameB matches the hostnameA. HostnameA is treated as mask
+// to be checked against the hostnameB.
 func HostnamesMatch(hostnameA, hostnameB string) bool {
-	labelsA := strings.Split(hostnameA, ".")
-	labelsB := strings.Split(hostnameB, ".")
+	// the hostnames are in the form of "foo.bar.com"; split them
+	// in a slice of substrings
+	hostnameALabels := strings.Split(hostnameA, ".")
+	hostnameBLabels := strings.Split(hostnameB, ".")
 
-	var i, j int
+	var a, b int
 	var wildcard bool
 
-	for i, j = 0, 0; i < len(labelsA) && j < len(labelsB); i, j = i+1, j+1 {
+	// iterate over the parts of both the hostnames
+	for a, b = 0, 0; a < len(hostnameALabels) && b < len(hostnameBLabels); a, b = a+1, b+1 {
+		var matchFound bool
+
+		// if the current part of B is a wildcard, we need to find the first
+		// A part that matches with the following B part
 		if wildcard {
-			for ; j < len(labelsB); j++ {
-				if labelsA[i] == labelsB[j] {
+			for ; b < len(hostnameBLabels); b++ {
+				if hostnameALabels[a] == hostnameBLabels[b] {
+					matchFound = true
 					break
 				}
 			}
-			if j == len(labelsB) {
-				return false
-			}
 		}
 
-		if labelsA[i] == "*" {
+		// if no match was found, the hostnames don't match
+		if wildcard && !matchFound {
+			return false
+		}
+
+		// check if at least on of the current parts are a wildcard; if so, continue
+		if hostnameALabels[a] == "*" {
 			wildcard = true
-			j--
 			continue
 		}
-
+		// reset the wildcard  variables
 		wildcard = false
 
-		if labelsA[i] != labelsB[j] {
+		// if the current a part is different from the b part, the hostnames are incompatible
+		if hostnameALabels[a] != hostnameBLabels[b] {
 			return false
 		}
 	}
-
-	return len(labelsA)-i == len(labelsB)-j
+	return len(hostnameBLabels)-b == len(hostnameALabels)-a
 }
 
 func routeMatchesListenerAllowedRoutes(