resolve comments

Author: dspo

internal/controller/httproute_controller.go

@@ -433,10 +433,7 @@ func (r *HTTPRouteReconciler) processHTTPRouteBackendRefs(tctx *provider.Transla
 		}
 
 		if backend.Kind != nil && *backend.Kind != "Service" {
-			terr = ReasonError{
-				Reason:  string(gatewayv1.RouteReasonInvalidKind),
-				Message: fmt.Sprintf("invalid kind %s, only Service is supported", *backend.Kind),
-			}
+			terr = newInvalidKindError(*backend.Kind)
 			continue
 		}
 

internal/manager/run.go

@@ -184,7 +184,7 @@ func Run(ctx context.Context, logger logr.Logger) error {
 		Resource: "referencegrants",
 	})
 	if err != nil {
-		logger.Error(err, "CRD ReferenceGrants is not installed")
+		setupLog.Info("CRD ReferenceGrants is not installed", "err", err)
 	}
 	controller.SetEnableReferenceGrant(err == nil)
 

test/conformance/conformance_test.go

@@ -24,7 +24,7 @@ var skippedTestsForSSL = []string{
 	tests.HTTPRouteRedirectPortAndScheme.ShortName,
 }
 
-var skippedTestsForTraditionalRoutes []string // TODO: HTTPRoute hostname intersection and listener hostname matching
+// TODO: HTTPRoute hostname intersection and listener hostname matching
 
 var gatewaySupportedFeatures = []features.FeatureName{
 	features.SupportGateway,
@@ -44,7 +44,7 @@ func TestGatewayAPIConformance(t *testing.T) {
 	opts.CleanupBaseResources = true
 	opts.GatewayClassName = gatewayClassName
 	opts.SupportedFeatures = sets.New(gatewaySupportedFeatures...)
-	opts.SkipTests = append(skippedTestsForSSL, skippedTestsForTraditionalRoutes...)
+	opts.SkipTests = skippedTestsForSSL
 	opts.Implementation = conformancev1.Implementation{
 		Organization: "APISIX",
 		Project:      "apisix-ingress-controller",
@@ -73,6 +73,6 @@ func TestGatewayAPIConformance(t *testing.T) {
 	if err != nil {
 		t.Fatalf("failed to marshal the gateway conformance test report: %v", err)
 	}
-	// Save report in root of the repository, file name is in .gitignore.
+	// Save report in the root of the repository, file name is in .gitignore.
 	require.NoError(t, os.WriteFile("../../"+reportFileName, rawReport, 0o600))
 }