Skip to content

Commit c6402b9

Browse files
committed
fix test
1 parent 4cd5673 commit c6402b9

File tree

5 files changed

+7
-18
lines changed

5 files changed

+7
-18
lines changed

internal/controller/apisixglobalrule_controller.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -165,10 +165,7 @@ func (r *ApisixGlobalRuleReconciler) checkIngressClass(obj client.Object) bool {
165165

166166
// listGlobalRulesForIngressClass list all global rules that use a specific ingress class
167167
func (r *ApisixGlobalRuleReconciler) listGlobalRulesForIngressClass(ctx context.Context, obj client.Object) []reconcile.Request {
168-
ingressClass, ok := obj.(*networkingv1.IngressClass)
169-
if !ok {
170-
return nil
171-
}
168+
ingressClass := convertIngressClass(obj)
172169

173170
return ListMatchingRequests(
174171
ctx,

internal/controller/apisixroute_controller.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import (
3030
corev1 "k8s.io/api/core/v1"
3131
discoveryv1 "k8s.io/api/discovery/v1"
3232
networkingv1 "k8s.io/api/networking/v1"
33+
networkingv1beta1 "k8s.io/api/networking/v1beta1"
3334
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
3435
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
3536
"k8s.io/apimachinery/pkg/runtime"
@@ -77,7 +78,7 @@ func (r *ApisixRouteReconciler) SetupWithManager(mgr ctrl.Manager) error {
7778
),
7879
).
7980
Watches(
80-
&networkingv1.IngressClass{},
81+
&networkingv1beta1.IngressClass{},
8182
handler.EnqueueRequestsFromMapFunc(r.listApisixRouteForIngressClass),
8283
builder.WithPredicates(
8384
predicate.NewPredicateFuncs(matchesIngressController),
@@ -498,10 +499,7 @@ func (r *ApisixRouteReconciler) listApisixRoutesForSecret(ctx context.Context, o
498499
}
499500

500501
func (r *ApisixRouteReconciler) listApisixRouteForIngressClass(ctx context.Context, object client.Object) (requests []reconcile.Request) {
501-
ingressClass, ok := object.(*networkingv1.IngressClass)
502-
if !ok {
503-
return nil
504-
}
502+
ingressClass := convertIngressClass(object)
505503

506504
return ListMatchingRequests(
507505
ctx,

internal/controller/apisixtls_controller.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -264,10 +264,7 @@ func (r *ApisixTlsReconciler) listApisixTlsForSecret(ctx context.Context, obj cl
264264

265265
// listApisixTlsForIngressClass list all TLS that use a specific ingress class
266266
func (r *ApisixTlsReconciler) listApisixTlsForIngressClass(ctx context.Context, obj client.Object) []reconcile.Request {
267-
ingressClass, ok := obj.(*networkingv1.IngressClass)
268-
if !ok {
269-
return nil
270-
}
267+
ingressClass = convertIngressClass(obj)
271268

272269
return ListMatchingRequests(
273270
ctx,

internal/controller/utils.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1259,10 +1259,7 @@ func listIngressClassRequestsForGatewayProxy(
12591259
}
12601260

12611261
func matchesIngressController(obj client.Object) bool {
1262-
ingressClass, ok := obj.(*networkingv1.IngressClass)
1263-
if !ok {
1264-
return false
1265-
}
1262+
ingressClass := convertIngressClass(obj)
12661263
return matchesController(ingressClass.Spec.Controller)
12671264
}
12681265

test/e2e/crds/v2/route.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ var _ = Describe("Test ApisixRoute", Label("apisix.apache.org", "v2", "apisixrou
5959

6060
Context("Test ApisixRoute", func() {
6161

62-
It("Basic tests", func() {
62+
FIt("Basic tests", func() {
6363
const apisixRouteSpec = `
6464
apiVersion: apisix.apache.org/v2
6565
kind: ApisixRoute

0 commit comments

Comments
 (0)