Skip to content

Commit cb519cd

Browse files
committed
fix test
1 parent 5a80e43 commit cb519cd

File tree

4 files changed

+25
-19
lines changed

4 files changed

+25
-19
lines changed

internal/provider/api7ee/provider.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ func (d *api7eeProvider) NeedLeaderElection() bool {
262262

263263
// updateConfigForGatewayProxy update config for all referrers of the GatewayProxy
264264
func (d *api7eeProvider) updateConfigForGatewayProxy(tctx *provider.TranslateContext, gp *v1alpha1.GatewayProxy) error {
265-
config, err := d.translator.TranslateGatewayProxyToConfig(tctx, gp, "")
265+
config, err := d.translator.TranslateGatewayProxyToConfig(tctx, gp, d.ResolveEndpoints)
266266
if err != nil {
267267
return err
268268
}
@@ -282,7 +282,7 @@ func (d *api7eeProvider) updateConfigForGatewayProxy(tctx *provider.TranslateCon
282282
func (d *api7eeProvider) buildConfig(tctx *provider.TranslateContext, nnk types.NamespacedNameKind) (map[types.NamespacedNameKind]adctypes.Config, error) {
283283
configs := make(map[types.NamespacedNameKind]adctypes.Config, len(tctx.ResourceParentRefs[nnk]))
284284
for _, gp := range tctx.GatewayProxies {
285-
config, err := d.translator.TranslateGatewayProxyToConfig(tctx, &gp, "")
285+
config, err := d.translator.TranslateGatewayProxyToConfig(tctx, &gp, d.ResolveEndpoints)
286286
if err != nil {
287287
return nil, err
288288
}

internal/provider/apisix/provider.go

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ import (
4343
pkgutils "github.com/apache/apisix-ingress-controller/pkg/utils"
4444
)
4545

46-
const ProviderType = "apisix"
47-
const ProviderTypeAPISIXStandalone = "apisix-standalone"
46+
const ProviderTypeAPISIX = "apisix"
4847

4948
type apisixProvider struct {
5049
provider.Options
@@ -66,7 +65,7 @@ func New(updater status.Updater, readier readiness.ReadinessManager, opts ...pro
6665
o := provider.Options{}
6766
o.ApplyOptions(opts)
6867
if o.BackendMode == "" {
69-
o.BackendMode = ProviderType
68+
o.BackendMode = ProviderTypeAPISIX
7069
}
7170

7271
cli, err := adcclient.New(o.BackendMode)
@@ -215,12 +214,8 @@ func (d *apisixProvider) Delete(ctx context.Context, obj client.Object) error {
215214

216215
func (d *apisixProvider) buildConfig(tctx *provider.TranslateContext, nnk types.NamespacedNameKind) (map[types.NamespacedNameKind]adctypes.Config, error) {
217216
configs := make(map[types.NamespacedNameKind]adctypes.Config, len(tctx.ResourceParentRefs[nnk]))
218-
var mode string
219-
if d.BackendMode == ProviderTypeAPISIXStandalone {
220-
mode = "endpoints"
221-
}
222217
for _, gp := range tctx.GatewayProxies {
223-
config, err := d.translator.TranslateGatewayProxyToConfig(tctx, &gp, mode)
218+
config, err := d.translator.TranslateGatewayProxyToConfig(tctx, &gp, d.ResolveEndpoints)
224219
if err != nil {
225220
return nil, err
226221
}
@@ -290,11 +285,7 @@ func (d *apisixProvider) NeedLeaderElection() bool {
290285

291286
// updateConfigForGatewayProxy update config for all referrers of the GatewayProxy
292287
func (d *apisixProvider) updateConfigForGatewayProxy(tctx *provider.TranslateContext, gp *v1alpha1.GatewayProxy) error {
293-
var mode string
294-
if d.BackendMode == ProviderTypeAPISIXStandalone {
295-
mode = "endpoints"
296-
}
297-
config, err := d.translator.TranslateGatewayProxyToConfig(tctx, gp, mode)
288+
config, err := d.translator.TranslateGatewayProxyToConfig(tctx, gp, d.ResolveEndpoints)
298289
if err != nil {
299290
return err
300291
}

internal/provider/init/init.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ func init() {
2929
provider.Register("apisix", apisix.New)
3030
provider.Register("apisix-standalone", func(statusUpdater status.Updater, readinessManager readiness.ReadinessManager, opts ...provider.Option) (provider.Provider, error) {
3131
opts = append(opts, provider.WithBackendMode("apisix-standalone"))
32+
opts = append(opts, provider.WithResolveEndpoints())
3233
return apisix.New(statusUpdater, readinessManager, opts...)
3334
})
3435
provider.Register("api7ee", api7ee.New)

internal/provider/options.go

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,11 @@ type Option interface {
2424
}
2525

2626
type Options struct {
27-
SyncTimeout time.Duration
28-
SyncPeriod time.Duration
29-
InitSyncDelay time.Duration
30-
BackendMode string
27+
SyncTimeout time.Duration
28+
SyncPeriod time.Duration
29+
InitSyncDelay time.Duration
30+
BackendMode string
31+
ResolveEndpoints bool
3132
}
3233

3334
func (o *Options) ApplyToList(lo *Options) {
@@ -43,6 +44,9 @@ func (o *Options) ApplyToList(lo *Options) {
4344
if o.BackendMode != "" {
4445
lo.BackendMode = o.BackendMode
4546
}
47+
if o.ResolveEndpoints {
48+
lo.ResolveEndpoints = o.ResolveEndpoints
49+
}
4650
}
4751

4852
func (o *Options) ApplyOptions(opts []Option) *Options {
@@ -61,3 +65,13 @@ func (b backendModeOption) ApplyToList(o *Options) {
6165
func WithBackendMode(mode string) Option {
6266
return backendModeOption(mode)
6367
}
68+
69+
type resolveEndpointsOption bool
70+
71+
func (r resolveEndpointsOption) ApplyToList(o *Options) {
72+
o.ResolveEndpoints = bool(r)
73+
}
74+
75+
func WithResolveEndpoints() Option {
76+
return resolveEndpointsOption(true)
77+
}

0 commit comments

Comments
 (0)