resolve comments

Author: dspo

test/conformance/apisix/suite_test.go

@@ -161,7 +161,7 @@ func TestMain(m *testing.M) {
 		Namespace:          namespace,
 		StatusAddress:      address,
 		InitSyncDelay:      1 * time.Minute,
-		ProviderType:       cmp.Or(os.Getenv(framework.EnvKeyProviderType), "apisix-standalone"),
+		ProviderType:       cmp.Or(framework.ProviderType, "apisix-standalone"),
 		ProviderSyncPeriod: 10 * time.Millisecond,
 	})
 

test/e2e/framework/apisix_consts.go

@@ -14,13 +14,14 @@ package framework
 
 import (
 	_ "embed"
+	"os"
 	"text/template"
 
 	"github.com/Masterminds/sprig/v3"
 )
 
-const (
-	EnvKeyProviderType = "PROVIDER_TYPE"
+var (
+	ProviderType = os.Getenv("PROVIDER_TYPE")
 )
 
 var (

test/e2e/framework/manifests/etcd.yaml

@@ -38,4 +38,4 @@ spec:
   - port: 2379
     targetPort: 2379
   selector:
-    app: etcd
+    app: etcd

test/e2e/scaffold/adc.go

@@ -132,8 +132,8 @@ func (a *adcDataplaneResource) dumpResources(ctx context.Context) (*translator.T
 		"ADC_SERVER=" + a.serverAddr,
 		"ADC_TOKEN=" + a.token,
 	}
-	if providerType := os.Getenv(framework.EnvKeyProviderType); providerType != "" {
-		adcEnv = append(adcEnv, "ADC_BACKEND="+providerType)
+	if framework.ProviderType != "" {
+		adcEnv = append(adcEnv, "ADC_BACKEND="+framework.ProviderType)
 	}
 
 	var stdout, stderr bytes.Buffer

test/e2e/scaffold/apisix_deployer.go

@@ -194,7 +194,7 @@ func (s *APISIXDeployer) deployDataplane(opts *APISIXDeployOptions) *corev1.Serv
 
 	kubectlOpts := k8s.NewKubectlOptions("", "", opts.Namespace)
 
-	if os.Getenv(framework.EnvKeyProviderType) == adc.BackendModeAPISIX {
+	if framework.ProviderType == adc.BackendModeAPISIX {
 		opts.ServiceName = "apisix"
 		opts.ConfigProvider = "etcd"
 		// deploy etcd
@@ -236,7 +236,7 @@ func (s *APISIXDeployer) deployDataplane(opts *APISIXDeployOptions) *corev1.Serv
 func (s *APISIXDeployer) DeployIngress() {
 	s.Framework.DeployIngress(framework.IngressDeployOpts{
 		ControllerName:     s.opts.ControllerName,
-		ProviderType:       cmp.Or(os.Getenv(framework.EnvKeyProviderType), "apisix-standalone"),
+		ProviderType:       cmp.Or(framework.ProviderType, "apisix-standalone"),
 		ProviderSyncPeriod: 200 * time.Millisecond,
 		Namespace:          s.namespace,
 		Replicas:           1,
@@ -246,7 +246,7 @@ func (s *APISIXDeployer) DeployIngress() {
 func (s *APISIXDeployer) ScaleIngress(replicas int) {
 	s.Framework.DeployIngress(framework.IngressDeployOpts{
 		ControllerName:     s.opts.ControllerName,
-		ProviderType:       cmp.Or(os.Getenv(framework.EnvKeyProviderType), "apisix-standalone"),
+		ProviderType:       cmp.Or(framework.ProviderType, "apisix-standalone"),
 		ProviderSyncPeriod: 200 * time.Millisecond,
 		Namespace:          s.namespace,
 		Replicas:           replicas,