fix: review

Signed-off-by: Ashing Zheng <[email protected]>

Author: ronething

internal/adc/client/client.go

@@ -39,7 +39,7 @@ import (
 )
 
 type Client struct {
-	syncMu sync.Mutex
+	syncMu sync.RWMutex
 	mu     sync.Mutex
 	*cache.Store
 
@@ -97,6 +97,9 @@ func (d *Client) Update(ctx context.Context, args Task) error {
 	}
 	d.mu.Unlock()
 
+	d.syncMu.RLock()
+	defer d.syncMu.RUnlock()
+
 	if len(deleteConfigs) > 0 {
 		err := d.sync(ctx, Task{
 			Name:          args.Name,
@@ -108,6 +111,7 @@ func (d *Client) Update(ctx context.Context, args Task) error {
 			log.Warnw("failed to sync deleted configs", zap.Error(err))
 		}
 	}
+
 	return d.sync(ctx, args)
 }
 
@@ -154,6 +158,9 @@ func (d *Client) Delete(ctx context.Context, args Task) error {
 	}
 	d.mu.Unlock()
 
+	d.syncMu.RLock()
+	defer d.syncMu.RUnlock()
+
 	return d.sync(ctx, Task{
 		Labels:        args.Labels,
 		ResourceTypes: args.ResourceTypes,

internal/provider/api7ee/provider.go

@@ -212,11 +212,11 @@ func (d *api7eeProvider) Delete(ctx context.Context, obj client.Object) error {
 func (d *api7eeProvider) Start(ctx context.Context) error {
 	d.readier.WaitReady(ctx, 5*time.Minute)
 
+	d.startUpSync.Store(true)
 	log.Info("Performing startup synchronization")
 	if err := d.sync(ctx); err != nil {
 		log.Warnw("failed to sync for startup", zap.Error(err))
 	}
-	d.startUpSync.Store(true)
 
 	initalSyncDelay := d.InitSyncDelay
 	if initalSyncDelay > 0 {