fix tests'

Author: Revolyssup

internal/controlplane/controlplane.go

@@ -74,7 +74,8 @@ func (d *dashboardClient) Update(ctx context.Context, tctx *translator.Translate
 				return err
 			}
 		} else {
-			ssl.Snis = append(ssl.Snis, oldssl.Snis...)
+			// array union is done to avoid host duplication
+			ssl.Snis = arrayUnion(ssl.Snis, oldssl.Snis)
 			if _, err := d.c.Cluster(name).SSL().Update(ctx, ssl); err != nil {
 				return err
 			}
@@ -83,6 +84,25 @@ func (d *dashboardClient) Update(ctx context.Context, tctx *translator.Translate
 	return nil
 }
 
+func arrayUnion(arr1 []string, arr2 []string) []string {
+	// return a union of elements from both array
+	presentEle := make(map[string]bool)
+	newArr := make([]string, 0)
+	for _, ele := range arr1 {
+		if !presentEle[ele] {
+			presentEle[ele] = true
+			newArr = append(newArr, ele)
+		}
+	}
+	for _, ele := range arr2 {
+		if !presentEle[ele] {
+			presentEle[ele] = true
+			newArr = append(newArr, ele)
+		}
+	}
+	return newArr
+}
+
 func (d *dashboardClient) Delete(ctx context.Context, obj client.Object) error {
 	clusters := d.c.ListClusters()
 	kindLabel := dashboard.ListByKindLabelOptions{

test/e2e/gatewayapi/gateway.go

@@ -227,15 +227,6 @@ spec:
 			assert.Len(GinkgoT(), tls, 1, "tls number not expect")
 			assert.Equal(GinkgoT(), Cert, tls[0].Cert, "tls cert not expect")
 			assert.Equal(GinkgoT(), []string{host}, tls[0].Snis)
-
-			By("Delete Gateway")
-			err = s.DeleteResource("Gateway", "api7ee")
-			Expect(err).NotTo(HaveOccurred(), "deleting Gateway")
-			time.Sleep(5 * time.Second)
-
-			tls, err = s.DefaultDataplaneResource().SSL().List(context.Background())
-			assert.Nil(GinkgoT(), err, "list tls error")
-			assert.Len(GinkgoT(), tls, 0, "tls number not expect")
 		})
 
 		Context("Gateway SSL with and without hostname", func() {