Skip to content

Commit ecf8675

Browse files
committed
fix: r
Signed-off-by: ashing <[email protected]>
1 parent ae6afdb commit ecf8675

File tree

3 files changed

+3
-25
lines changed

3 files changed

+3
-25
lines changed

internal/controller/apisixpluginconfig_controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ func (r *ApisixPluginConfigReconciler) processIngressClassParameters(ctx context
226226
}
227227

228228
func (r *ApisixPluginConfigReconciler) updateStatus(pc *apiv2.ApisixPluginConfig, err error) {
229-
SetApisixPluginConfigConditionAccepted(&pc.Status, pc.GetGeneration(), err)
229+
SetApisixCRDConditionAccepted(&pc.Status, pc.GetGeneration(), err)
230230
r.Updater.Update(status.Update{
231231
NamespacedName: utils.NamespacedName(pc),
232232
Resource: &apiv2.ApisixPluginConfig{},

internal/controller/apisixroute_controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -537,7 +537,7 @@ func (r *ApisixRouteReconciler) processIngressClassParameters(ctx context.Contex
537537
}
538538

539539
func (r *ApisixRouteReconciler) updateStatus(ar *apiv2.ApisixRoute, err error) {
540-
SetApisixRouteConditionAccepted(&ar.Status, ar.GetGeneration(), err)
540+
SetApisixCRDConditionAccepted(&ar.Status, ar.GetGeneration(), err)
541541
r.Updater.Update(status.Update{
542542
NamespacedName: utils.NamespacedName(ar),
543543
Resource: &apiv2.ApisixRoute{},

internal/controller/utils.go

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -411,29 +411,7 @@ func ParseRouteParentRefs(
411411
return gateways, nil
412412
}
413413

414-
func SetApisixRouteConditionAccepted(status *apiv2.ApisixStatus, generation int64, err error) {
415-
var condition = metav1.Condition{
416-
Type: string(apiv2.ConditionTypeAccepted),
417-
Status: metav1.ConditionTrue,
418-
ObservedGeneration: generation,
419-
LastTransitionTime: metav1.Now(),
420-
Reason: string(apiv2.ConditionReasonAccepted),
421-
}
422-
if err != nil {
423-
condition.Status = metav1.ConditionFalse
424-
condition.Reason = string(apiv2.ConditionReasonInvalidSpec)
425-
condition.Message = err.Error()
426-
427-
var re ReasonError
428-
if errors.As(err, &re) {
429-
condition.Reason = re.Reason
430-
}
431-
}
432-
433-
status.Conditions = []metav1.Condition{condition}
434-
}
435-
436-
func SetApisixPluginConfigConditionAccepted(status *apiv2.ApisixStatus, generation int64, err error) {
414+
func SetApisixCRDConditionAccepted(status *apiv2.ApisixStatus, generation int64, err error) {
437415
var condition = metav1.Condition{
438416
Type: string(apiv2.ConditionTypeAccepted),
439417
Status: metav1.ConditionTrue,

0 commit comments

Comments
 (0)