Skip to content

Commit f41ff65

Browse files
committed
fix: pass more test
Signed-off-by: ashing <[email protected]>
1 parent fee56d5 commit f41ff65

File tree

3 files changed

+18
-16
lines changed

3 files changed

+18
-16
lines changed

.github/workflows/conformance-test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ jobs:
3333
go install sigs.k8s.io/[email protected]
3434
3535
conformance-test:
36+
timeout-minutes: 60
3637
needs:
3738
- prepare
3839
runs-on: buildjet-2vcpu-ubuntu-2204

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ e2e-test:
108108

109109
.PHONY: conformance-test
110110
conformance-test:
111-
DASHBOARD_VERSION=$(DASHBOARD_VERSION) go test -v ./test/conformance -tags=conformance
111+
DASHBOARD_VERSION=$(DASHBOARD_VERSION) go test -v ./test/conformance -tags=conformance -timeout 60m
112112

113113
.PHONY: lint
114114
lint: golangci-lint ## Run golangci-lint linter

test/conformance/conformance_test.go

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -26,34 +26,34 @@ var skippedTestsForSSL = []string{
2626

2727
var skippedTestsForTraditionalRoutes = []string{
2828
// TODO: Support ReferenceGrant resource
29-
tests.HTTPRouteInvalidReferenceGrant.ShortName,
30-
tests.HTTPRoutePartiallyInvalidViaInvalidReferenceGrant.ShortName,
31-
tests.HTTPRouteReferenceGrant.ShortName,
3229
tests.GatewayInvalidTLSConfiguration.ShortName,
30+
tests.GatewaySecretInvalidReferenceGrant.ShortName,
3331
tests.GatewaySecretMissingReferenceGrant.ShortName,
32+
tests.GatewaySecretReferenceGrantAllInNamespace.ShortName,
33+
tests.GatewaySecretReferenceGrantSpecific.ShortName,
3434
/*
3535
tests.GatewayInvalidTLSConfiguration.ShortName,
3636
tests.GatewayModifyListeners.ShortName,
3737
tests.GatewayWithAttachedRoutes.ShortName,
3838
*/
39+
tests.HTTPRouteExactPathMatching.ShortName,
3940
tests.HTTPRouteHTTPSListener.ShortName,
4041
tests.HTTPRouteHeaderMatching.ShortName,
41-
tests.HTTPRouteMatching.ShortName,
42-
tests.HTTPRouteExactPathMatching.ShortName,
42+
tests.HTTPRouteHostnameIntersection.ShortName,
4343
tests.HTTPRouteInvalidBackendRefUnknownKind.ShortName,
44-
tests.HTTPRouteInvalidNonExistentBackendRef.ShortName,
44+
tests.HTTPRouteInvalidCrossNamespaceBackendRef.ShortName,
4545
tests.HTTPRouteInvalidCrossNamespaceParentRef.ShortName,
46+
tests.HTTPRouteInvalidNonExistentBackendRef.ShortName,
4647
tests.HTTPRouteInvalidParentRefNotMatchingSectionName.ShortName,
47-
tests.HTTPRouteRequestHeaderModifier.ShortName,
48-
tests.HTTPRouteWeight.ShortName,
49-
tests.HTTPRouteHostnameIntersection.ShortName,
48+
tests.HTTPRouteInvalidReferenceGrant.ShortName,
49+
tests.HTTPRouteInvalidReferenceGrant.ShortName,
5050
tests.HTTPRouteListenerHostnameMatching.ShortName,
51+
tests.HTTPRouteMatching.ShortName,
5152
tests.HTTPRouteMatchingAcrossRoutes.ShortName,
52-
tests.GatewaySecretReferenceGrantSpecific.ShortName,
53-
tests.GatewaySecretInvalidReferenceGrant.ShortName,
54-
tests.GatewaySecretReferenceGrantAllInNamespace.ShortName,
55-
tests.HTTPRouteInvalidCrossNamespaceBackendRef.ShortName,
56-
tests.HTTPRouteInvalidReferenceGrant.ShortName,
53+
tests.HTTPRoutePartiallyInvalidViaInvalidReferenceGrant.ShortName,
54+
tests.HTTPRouteReferenceGrant.ShortName,
55+
tests.HTTPRouteRequestHeaderModifier.ShortName,
56+
tests.HTTPRouteWeight.ShortName,
5757
}
5858

5959
var gatewaySupportedFeatures = []features.FeatureName{
@@ -74,7 +74,8 @@ func TestGatewayAPIConformance(t *testing.T) {
7474
opts.CleanupBaseResources = true
7575
opts.GatewayClassName = gatewayClassName
7676
opts.SupportedFeatures = sets.New(gatewaySupportedFeatures...)
77-
opts.SkipTests = append(skippedTestsForSSL, skippedTestsForTraditionalRoutes...)
77+
// opts.SkipTests = append(skippedTestsForSSL, skippedTestsForTraditionalRoutes...)
78+
opts.SkipTests = skippedTestsForSSL
7879
opts.Implementation = conformancev1.Implementation{
7980
Organization: "API7",
8081
Project: "api7-ingress-controller",

0 commit comments

Comments
 (0)