Skip to content

Commit fa773d9

Browse files
committed
fix test
1 parent 05640d9 commit fa773d9

File tree

3 files changed

+42
-44
lines changed

3 files changed

+42
-44
lines changed

internal/controller/gatewayproxy_controller.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,8 @@ func (r *GatewayProxyController) Reconcile(ctx context.Context, req ctrl.Request
159159
}
160160

161161
switch r.ICGV.String() {
162-
case networkingv1.SchemeGroupVersion.String(), "":
163-
var ingressClassList networkingv1.IngressClassList
162+
case networkingv1beta1.SchemeGroupVersion.String():
163+
var ingressClassList networkingv1beta1.IngressClassList
164164
// list IngressClasses that reference the GatewayProxy
165165
if err := r.List(ctx, &ingressClassList, client.MatchingFields{indexer.IngressClassParametersRef: indexKey}); err != nil {
166166
r.Log.Error(err, "failed to list IngressClassList")
@@ -170,8 +170,8 @@ func (r *GatewayProxyController) Reconcile(ctx context.Context, req ctrl.Request
170170
for _, item := range ingressClassList.Items {
171171
tctx.GatewayProxyReferrers[req.NamespacedName] = append(tctx.GatewayProxyReferrers[req.NamespacedName], utils.NamespacedNameKind(&item))
172172
}
173-
case networkingv1beta1.SchemeGroupVersion.String():
174-
var ingressClassList networkingv1beta1.IngressClassList
173+
default:
174+
var ingressClassList networkingv1.IngressClassList
175175
// list IngressClasses that reference the GatewayProxy
176176
if err := r.List(ctx, &ingressClassList, client.MatchingFields{indexer.IngressClassParametersRef: indexKey}); err != nil {
177177
r.Log.Error(err, "failed to list IngressClassList")

internal/controller/utils.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1453,16 +1453,14 @@ func GetIngressClassv1(ctx context.Context, c client.Client, log logr.Logger, in
14531453

14541454
func GetIngressClass(ctx context.Context, c client.Client, log logr.Logger, ingressClassName string, apiVersion string) (*networkingv1.IngressClass, error) {
14551455
switch apiVersion {
1456-
case networkingv1beta1.SchemeGroupVersion.String(), "":
1456+
case networkingv1beta1.SchemeGroupVersion.String():
14571457
icBeta, err := GetIngressClassV1Beta1(ctx, c, log, ingressClassName)
14581458
if err != nil {
14591459
return nil, err
14601460
}
14611461
return convertIngressClass(icBeta), nil
1462-
case networkingv1.SchemeGroupVersion.String():
1463-
return GetIngressClassv1(ctx, c, log, ingressClassName)
14641462
default:
1465-
return nil, fmt.Errorf("unsupported IngressClass API version: %s", apiVersion)
1463+
return GetIngressClassv1(ctx, c, log, ingressClassName)
14661464
}
14671465
}
14681466

test/e2e/gatewayapi/status.go

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -40,61 +40,61 @@ var _ = Describe("Test Gateway API Status", Label("apisix.apache.org", "v2", "ap
4040
apiVersion: gateway.networking.k8s.io/v1
4141
kind: HTTPRoute
4242
metadata:
43-
name: httpbin
43+
name: httpbin
4444
spec:
45-
parentRefs:
46-
- name: apisix
47-
hostnames:
48-
- "httpbin"
49-
rules:
50-
- matches:
51-
- path:
52-
type: Exact
53-
value: /get
54-
backendRefs:
55-
- name: httpbin-service-e2e-test
56-
port: 80
45+
parentRefs:
46+
- name: apisix
47+
hostnames:
48+
- "httpbin"
49+
rules:
50+
- matches:
51+
- path:
52+
type: Exact
53+
value: /get
54+
backendRefs:
55+
- name: httpbin-service-e2e-test
56+
port: 80
5757
`
5858
const gatewayClass = `
5959
apiVersion: gateway.networking.k8s.io/v1
6060
kind: GatewayClass
6161
metadata:
62-
name: %s
62+
name: %s
6363
spec:
64-
controllerName: %s
64+
controllerName: %s
6565
`
6666
const gatewayProxy = `
6767
apiVersion: apisix.apache.org/v1alpha1
6868
kind: GatewayProxy
6969
metadata:
70-
name: apisix-proxy-config
70+
name: apisix-proxy-config
7171
spec:
72-
provider:
73-
type: ControlPlane
74-
controlPlane:
75-
endpoints:
76-
- %s
77-
auth:
78-
type: AdminKey
79-
adminKey:
80-
value: "%s"
72+
provider:
73+
type: ControlPlane
74+
controlPlane:
75+
endpoints:
76+
- %s
77+
auth:
78+
type: AdminKey
79+
adminKey:
80+
value: "%s"
8181
`
8282
const defaultGateway = `
8383
apiVersion: gateway.networking.k8s.io/v1
8484
kind: Gateway
8585
metadata:
86-
name: apisix
86+
name: apisix
8787
spec:
88-
gatewayClassName: %s
89-
listeners:
90-
- name: http1
91-
protocol: HTTP
92-
port: 80
93-
infrastructure:
94-
parametersRef:
95-
group: apisix.apache.org
96-
kind: GatewayProxy
97-
name: apisix-proxy-config
88+
gatewayClassName: %s
89+
listeners:
90+
- name: http1
91+
protocol: HTTP
92+
port: 80
93+
infrastructure:
94+
parametersRef:
95+
group: apisix.apache.org
96+
kind: GatewayProxy
97+
name: apisix-proxy-config
9898
`
9999
BeforeEach(func() {
100100
By("create GatewayProxy")

0 commit comments

Comments
 (0)