handle errors

Author: Revolyssup

internal/controller/gateway_controller.go

@@ -103,11 +103,12 @@ func (r *GatewayReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
 			status: false,
 			msg:    err.Error(),
 		}
-	}
-	if err := r.ControlPlaneClient.Update(ctx, tctx, gateway); err != nil {
-		acceptStatus = status{
-			status: false,
-			msg:    err.Error(),
+	} else {
+		if err := r.ControlPlaneClient.Update(ctx, tctx, gateway); err != nil {
+			acceptStatus = status{
+				status: false,
+				msg:    err.Error(),
+			}
 		}
 	}
 

internal/controlplane/translator/gateway.go

@@ -51,10 +51,6 @@ func (t *Translator) translateSecret(tctx *TranslateContext, listener gatewayv1.
 				}
 				name := listener.TLS.CertificateRefs[0].Name
 				secret := tctx.Secrets[types.NamespacedName{Namespace: ns, Name: string(ref.Name)}]
-				// if secret == nil {
-				// 	log.Error("secret not found", "namespace", ns, "name", name)
-				// 	return nil, fmt.Errorf("secret not found for %s/%s", ns, name)
-				// }
 				if secret.Data == nil {
 					log.Error("secret data is nil", "secret", secret)
 					return nil, fmt.Errorf("no secret data found for %s/%s", ns, name)