chore: refactor httpbin example #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the httpbin example configurations by updating the controllerName values, adding a dedicated GatewayProxy resource with infrastructure configuration, and updating service timeout and host rewrite settings.
- Updated controllerName to "gateway.apisix.io/api7-ingress-controller" in multiple example files.
- Introduced a standalone GatewayProxy resource with ControlPlane and AdminKey configuration.
- Added service-specific configurations for timeout and host rewrite.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/httpbin/service-timeout.yaml | Added BackendTrafficPolicy with timeout settings for the httpbin service. |
| examples/httpbin/service-rewrite-host.yaml | Added BackendTrafficPolicy with passHost rewrite and upstreamHost configuration. |
| examples/httpbin/quickstart.yaml | Updated the controllerName and added a GatewayProxy resource with infrastructure config. |
| examples/httpbin/ingress.yaml | Defined GatewayProxy, IngressClass, and Ingress resources for traffic routing. |
| examples/httpbin/httproute.yaml | Updated the controllerName and added GatewayProxy details in the routing config. |
Comments suppressed due to low confidence (2)
examples/httpbin/quickstart.yaml:64
- Ensure that the updated controllerName is consistent with the configuration expected by the deployed controller across all related example files.
controllerName: "gateway.apisix.io/api7-ingress-controller"
examples/httpbin/httproute.yaml:6
- Verify that this change to the controllerName aligns with the overall configuration, ensuring consistency across the examples.
controllerName: "gateway.apisix.io/api7-ingress-controller"
ronething
reviewed
Apr 21, 2025
| metadata: | ||
| name: httpbin | ||
| spec: | ||
| # 解析到 upstream.nodes 当中 |
ronething
reviewed
Apr 21, 2025
| metadata: | ||
| name: httpbin | ||
| spec: | ||
| # 解析到 upstream.nodes 当中 |
ronething
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
Pre-submission checklist: