fix: HTTPRouteHostnameIntersection test case #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Contributor
conformance test reportapiVersion: gateway.networking.k8s.io/v1
date: "2025-05-13T02:54:42Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
contact: null
organization: APISIX
project: apisix-ingress-controller
url: https://github.com/apache/apisix-ingress-controller.git
version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
failedTests:
- HTTPRouteListenerHostnameMatching
result: failure
skippedTests:
- GatewayInvalidTLSConfiguration
- GatewaySecretInvalidReferenceGrant
- GatewaySecretMissingReferenceGrant
- HTTPRouteHTTPSListener
- HTTPRouteInvalidCrossNamespaceBackendRef
- HTTPRouteInvalidCrossNamespaceParentRef
- HTTPRouteInvalidNonExistentBackendRef
- HTTPRouteInvalidParentRefNotMatchingSectionName
- HTTPRouteInvalidReferenceGrant
- HTTPRoutePartiallyInvalidViaInvalidReferenceGrant
- HTTPRouteReferenceGrant
statistics:
Failed: 1
Passed: 21
Skipped: 11
name: GATEWAY-HTTP
summary: Core tests failed with 1 test failures. |
dspo
approved these changes
May 13, 2025
Comment on lines
+237
to
+240
| reason := gatewayv1.RouteReasonAccepted | ||
| if message == ErrNoMatchingListenerHostname.Error() { | ||
| reason = gatewayv1.RouteReasonNoMatchingListenerHostname | ||
| } |
Contributor
There was a problem hiding this comment.
靠 message 来传递 reason 有点怪怪的，是否可以定义一种 error 类型，比如
type ReasonErr struct {
Reason string
Message string
}
func (e ReasonErr) Error() string { return e.Message }在前文相关函数中直接返回这样类型的错误，后文中用 errors.As 来判断错误类型，如果是 ReasonErr，可以取出 Reson。
Contributor
Author
There was a problem hiding this comment.
OK, but let's wait for the next PR to make a unified adjustment.
test/conformance/conformance_test.go
Outdated
Comment on lines
37
to
38
| // tests.HTTPRouteHostnameIntersection.ShortName, | ||
| // tests.HTTPRouteListenerHostnameMatching.ShortName, |
Signed-off-by: ashing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ashing [email protected]
Type of change:
What this PR does / why we need it:
Pre-submission checklist: