fix

Author: bzp2010

src/ngx_http_apisix_module.c

@@ -1069,8 +1069,7 @@ ngx_http_apisix_set_upstream_pass_trailers(ngx_http_request_t *r, int on)
 ngx_int_t
 ngx_http_apisix_is_upstream_pass_trailers(ngx_http_request_t *r)
 {
-    return 0;
-    /* ngx_http_apisix_ctx_t          *ctx;
+    ngx_http_apisix_ctx_t          *ctx;
 
     ctx = ngx_http_apisix_get_module_ctx(r);
 
@@ -1079,5 +1078,5 @@ ngx_http_apisix_is_upstream_pass_trailers(ngx_http_request_t *r)
         return ctx->upstream_pass_trailers;
     }
 
-    return 1; */
+    return 1;
 }

t/upstream_pass_trailers.t

@@ -52,16 +52,75 @@ GET /t
 
 
 
-=== TEST 2: do not pass upstream trailers to downstream
+=== TEST 2: pass upstream trailers to downstream
+Since the processing logic for the trailer is located in the upstream module, it must be tested via proxy_pass.
+--- http_config
+server {
+    listen 1985;
+    location /t {
+        add_trailer "foo" "bar";
+        echo "hello";
+    }
+}
 --- config
 location /up {
-    add_trailer "foo" "bar";
-    echo "hello";
+    proxy_pass http://127.0.0.1:1985/t;
+}
+location /t {
+    access_by_lua_block {
+        local upstream = require("resty.apisix.upstream")
+        assert(upstream.set_pass_trailers(true), 'failed to set pass trailers')
+    }
+
+    content_by_lua_block {
+        local sock = ngx.socket.tcp()
+
+        local ok, err = sock:connect("127.0.0.1", ngx.var.server_port)
+        if not ok then
+            ngx.say("failed to connect: ", err)
+            return
+        end
+        
+        local _, err = sock:send("GET /up HTTP/1.1\r\nHost: 127.0.0.1:1984\r\nUser-Agent: curl/8.5.0\r\nAccept: */*\r\nConnection: close\r\n\r\n")
+        if err then
+            ngx.say("failed to send: ", err)
+            return
+        end
+
+        local data, err, partial = sock:receive("*a")
+        if err then
+            ngx.say("failed to receive: ", err)
+            return
+        end
+
+        assert(string.find(data, "HTTP/1.1 200 OK", 1, true), "status not 200")
+        assert(not string.find(data, "Trailer: foo", 1, true), "exist trailer header")
+        assert(string.find(data, "foo: bar", 1, true), "missing trailer")
+    }
+}
+--- request
+GET /t
+
+
+
+=== TEST 3: do not pass upstream trailers to downstream
+Since the processing logic for the trailer is located in the upstream module, it must be tested via proxy_pass.
+--- http_config
+server {
+    listen 1985;
+    location /t {
+        add_trailer "foo" "bar";
+        echo "hello";
+    }
+}
+--- config
+location /up {
+    proxy_pass http://127.0.0.1:1985/t;
 }
 location /t {
     access_by_lua_block {
         local upstream = require("resty.apisix.upstream")
-        assert(upstream.set_pass_trailers(false))
+        assert(upstream.set_pass_trailers(false), 'failed to set pass trailers')
     }
 
     content_by_lua_block {