perf: used hash object confirm if there was a duplicated value in array. (#21)

Author: membphis

lib/jsonschema.lua

@@ -182,6 +182,7 @@ function codectx_mt:_get_loader()
 end
 
 function codectx_mt:as_string()
+  self:_get_loader()
   return tab_concat(self._code_table)
 end
 
@@ -329,6 +330,21 @@ end
 validatorlib.deepeq = deepeq
 
 
+local function unique_item_in_array(arr)
+    local existed_items = {}
+    for i, val in ipairs(arr) do
+        if existed_items[val] then
+          return false, existed_items[val], i
+        end
+
+        existed_items[val] = i
+    end
+
+    return true
+end
+validatorlib.unique_item_in_array = unique_item_in_array
+
+
 --
 -- Validation generator
 --
@@ -746,15 +762,10 @@ generate_validator = function(ctx, schema)
       ctx:stmt(        '  end')
     end
 
-    -- TODO: this is slow as hell, could be optimized by storing value items
-    -- in a spearate set, and calling deepeq only for references.
     if schema.uniqueItems then
-      ctx:stmt(sformat('  for i=2, #%s do', ctx:param(1)))
-      ctx:stmt(        '    for j=1, i-1 do')
-      ctx:stmt(sformat('      if %s(%s[i], %s[j]) then', ctx:libfunc('lib.deepeq'), ctx:param(1), ctx:param(1)))
-      ctx:stmt(sformat('        return false, %s("expected unique items but items %%d and %%d are equal", i, j)', ctx:libfunc('string.format')))
-      ctx:stmt(        '      end')
-      ctx:stmt(        '    end')
+      ctx:stmt(sformat('  local ok, item1, item2 = %s(%s)', ctx:libfunc('lib.unique_item_in_array'), ctx:param(1)))
+      ctx:stmt(sformat('  if not ok then', ctx:libfunc('lib.unique_item_in_array'), ctx:param(1)))
+      ctx:stmt(sformat('    return false, %s("expected unique items but items %%d and %%d are equal", item1, item2)', ctx:libfunc('string.format')))
       ctx:stmt(        '  end')
     end
     ctx:stmt('end') -- if array

t/default.lua

@@ -1,5 +1,5 @@
 local jsonschema = require 'jsonschema'
-
+----------------------------------------------------- test case 1
 local rule = {
     type = "object",
     properties = {
@@ -29,6 +29,7 @@ if not conf.rule then
   return
 end
 
+----------------------------------------------------- test case 2
 rule = {
   type = "object",
   properties = {
@@ -59,3 +60,32 @@ if ok then
 end
 
 ngx.say("passed: table value as default value")
+
+----------------------------------------------------- test case 3
+local rule = {
+  type = "array",
+  uniqueItems = true
+}
+
+validator = jsonschema.generate_validator(rule)
+
+local data = {}
+for i = 1, 1000 * 500 do
+  data[i] = i
+end
+
+ngx.update_time()
+local start_time = ngx.now()
+
+local ok, err = validator(data)
+if not ok then
+  ngx.say("fail: check uniqueItems array: ", err)
+end
+
+ngx.update_time()
+if ngx.now() - start_time > 0.1 then
+  ngx.say("fail: check uniqueItems array take more than 0.1s")
+  ngx.exit(-1)
+end
+
+ngx.say("passed: check uniqueItems array")