fix: we don't need to close http_cli after reading chunks failed (#167)

It will be closed by watchcancel method.

Signed-off-by: spacewander <[email protected]>

Author: spacewander

.github/workflows/ci.yml

@@ -37,7 +37,8 @@ jobs:
       - name: setup go
         uses: actions/[email protected]
         with:
-          go-version: "1.15"
+          # goreman requires 1.17
+          go-version: "1.17"
 
       - name: get dependencies
         run: sudo apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl

lib/resty/etcd/v3.lua

@@ -732,7 +732,6 @@ local function request_chunk(self, method, path, opts, timeout)
         while(1) do
             local chunk, read_err = res.body_reader()
             if read_err then
-                http_cli:close()
                 return nil, read_err
             end
             if not chunk then
@@ -760,21 +759,18 @@ local function request_chunk(self, method, path, opts, timeout)
 
         local chunks, split_err = split(body, [[\n]], "jo")
         if split_err then
-            http_cli:close()
             return nil, "failed to split chunks: " .. split_err
         end
 
         local all_events = {}
         for _, chunk in ipairs(chunks) do
             body, err = decode_json(chunk)
             if not body then
-                http_cli:close()
                 return nil, "failed to decode json body: " .. (err or " unknown")
             elseif body.error and body.error.http_code >= 500 then
                 -- health_check retry should do nothing here
                 -- and let connection closed to create a new one
                 health_check.report_failure(endpoint.http_host)
-                http_cli:close()
                 return nil, endpoint.http_host .. ": " .. body.error.http_status
             end