feat: remove req header (#54)

Author: spacewander

src/http/ngx_http_wasm_api.c

@@ -876,11 +876,21 @@ proxy_remove_header_map_value(int32_t type, int32_t key_data, int32_t key_size)
     must_get_req(r);
     must_get_memory(key, log, key_data, key_size);
 
-    if (type == PROXY_MAP_TYPE_HTTP_RESPONSE_HEADERS) {
+    switch (type) {
+    case PROXY_MAP_TYPE_HTTP_REQUEST_HEADERS:
+        rc = ngx_http_wasm_set_req_header(r, key, key_size, NULL, 0, 1);
+        break;
+
+    case PROXY_MAP_TYPE_HTTP_RESPONSE_HEADERS:
         rc = ngx_http_wasm_set_resp_header(r, key, key_size, 1, NULL, 0, 1);
-        if (rc != NGX_OK) {
-            return PROXY_RESULT_BAD_ARGUMENT;
-        }
+        break;
+
+    default:
+        return PROXY_RESULT_BAD_ARGUMENT;
+    }
+
+    if (rc != NGX_OK) {
+        return PROXY_RESULT_BAD_ARGUMENT;
     }
 
     return PROXY_RESULT_OK;

t/http_req_header.t

@@ -198,3 +198,62 @@ location /t {
 }
 --- response_body
 bar
+
+
+
+=== TEST 11: remove header
+--- config
+location /t {
+    access_by_lua_block {
+        local wasm = require("resty.proxy-wasm")
+        local plugin = assert(wasm.load("plugin", "t/testdata/http_header/main.go.wasm"))
+        local ctx = assert(wasm.on_configure(plugin, 'req_hdr_del'))
+        assert(wasm.on_http_request_headers(ctx))
+    }
+    content_by_lua_block {
+        ngx.say(ngx.req.get_headers()["foo"])
+    }
+}
+--- more_headers
+FOO: foo
+--- response_body
+nil
+
+
+
+=== TEST 12: remove header, missing
+--- config
+location /t {
+    access_by_lua_block {
+        local wasm = require("resty.proxy-wasm")
+        local plugin = assert(wasm.load("plugin", "t/testdata/http_header/main.go.wasm"))
+        local ctx = assert(wasm.on_configure(plugin, 'req_hdr_del'))
+        assert(wasm.on_http_request_headers(ctx))
+    }
+    content_by_lua_block {
+        ngx.say(ngx.req.get_headers()["foo"])
+    }
+}
+--- response_body
+nil
+
+
+
+=== TEST 13: remove header, all of it
+--- config
+location /t {
+    access_by_lua_block {
+        local wasm = require("resty.proxy-wasm")
+        local plugin = assert(wasm.load("plugin", "t/testdata/http_header/main.go.wasm"))
+        local ctx = assert(wasm.on_configure(plugin, 'req_hdr_del'))
+        assert(wasm.on_http_request_headers(ctx))
+    }
+    content_by_lua_block {
+        ngx.say(ngx.req.get_headers()["foo"])
+    }
+}
+--- more_headers
+FOO: foo
+FOO: bar
+--- response_body
+nil

t/testdata/http_header/main.go

@@ -71,6 +71,9 @@ func (ctx *httpContext) OnHttpRequestHeaders(numHeaders int, endOfStream bool) t
 
 	case "req_hdr_add":
 		proxywasm.AddHttpRequestHeader("foo", "bar")
+
+	case "req_hdr_del":
+		proxywasm.RemoveHttpRequestHeader("foo")
 	}
 
 	return types.ActionContinue