chore(deps): update dependency @apify/eslint-config to v1 (#765)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Vlad Frangu <[email protected]>

Author: renovate[bot]

.editorconfig

@@ -10,6 +10,14 @@ end_of_line = lf
 # editorconfig-tools is unable to ignore longs strings or urls
 max_line_length = null
 
+[*.ts]
+indent_style = tab
+indent_size = 4
+
+[*.js]
+indent_style = tab
+indent_size = 4
+
 [*.md]
 indent_size = 2
 

.eslintrc.json

@@ -0,0 +1,27 @@
+{
+	"[javascript]": {
+		"editor.defaultFormatter": "biomejs.biome"
+	},
+	"[javascriptreact]": {
+		"editor.defaultFormatter": "esbenp.prettier-vscode"
+	},
+	"[json]": {
+		"editor.defaultFormatter": "biomejs.biome"
+	},
+	"[typescript]": {
+		"editor.defaultFormatter": "biomejs.biome"
+	},
+	"[typescriptreact]": {
+		"editor.defaultFormatter": "biomejs.biome"
+	},
+	"[jsonc]": {
+		"editor.defaultFormatter": "biomejs.biome"
+	},
+	"[yaml]": {
+		"editor.defaultFormatter": "biomejs.biome"
+	},
+	"[markdown]": {
+		"editor.defaultFormatter": "esbenp.prettier-vscode",
+		"files.trimTrailingWhitespace": false
+	}
+}

.vscode/settings.json

@@ -0,0 +1,77 @@
+import prettier from 'eslint-config-prettier';
+import tsEslint from 'typescript-eslint';
+
+// eslint-disable-next-line import/extensions -- todo: the import/extensions rule should be replaced with something that can handle exports in a package.json
+import apify from '@apify/eslint-config/ts';
+
+export default [
+	{
+		ignores: [
+			'**/dist',
+			'node_modules',
+			'coverage',
+			'website/{build,.docusaurus}',
+			'**/*.d.ts',
+			'test/tmp/**/*',
+			'.yarn/**/*',
+		],
+	},
+	...apify,
+	prettier,
+	{
+		languageOptions: {
+			parser: tsEslint.parser,
+			parserOptions: {
+				project: 'tsconfig.eslint.json',
+			},
+		},
+	},
+	{
+		plugins: {
+			'@typescript-eslint': tsEslint.plugin,
+		},
+		rules: {
+			'no-use-before-define': 'off',
+			'@typescript-eslint/no-use-before-define': ['error', { functions: false }],
+
+			'no-console': 'off',
+
+			'no-param-reassign': 'off',
+			// We have env variables with _ in their name
+			'no-underscore-dangle': 'off',
+
+			// we do default exports
+			// TODO: remove once moved to yargs
+			'import/no-default-export': 'off',
+
+			'@typescript-eslint/consistent-type-imports': [
+				'error',
+				{
+					disallowTypeAnnotations: false,
+				},
+			],
+			'@typescript-eslint/consistent-type-definitions': ['error', 'interface'],
+
+			// Not ideal, but we still use any for simplicity
+			'@typescript-eslint/no-explicit-any': 'off',
+
+			// '@typescript-eslint/array-type': 'error',
+			// '@typescript-eslint/no-empty-object-type': 'off',
+		},
+	},
+	{
+		files: ['website/**/*'],
+		rules: {
+			'@typescript-eslint/no-shadow': 'off',
+			'no-console': 'off',
+			'no-undef': 'off',
+		},
+	},
+	{
+		files: ['src/**/*'],
+		rules: {
+			'no-console': 'off',
+			'consistent-return': 'off',
+		},
+	},
+];

eslint.config.mjs

@@ -10,8 +10,8 @@
         "test": "vitest run",
         "test-python": "vitest run -t '.*\\[python\\]'",
         "test:cucumber": "cross-env NODE_OPTIONS=\"--import tsx\" cucumber-js",
-        "lint": "eslint src test .yarn/plugins --ext .ts,.cjs,.mjs",
-        "lint:fix": "eslint src test .yarn/plugins --fix --ext .ts,.cjs,.mjs",
+        "lint": "eslint src test --ext .ts,.cjs,.mjs",
+        "lint:fix": "eslint src test --fix --ext .ts,.cjs,.mjs",
         "format": "biome format . && prettier --check \"**/*.{md,yml,yaml}\"",
         "format:fix": "biome format --write . && prettier --write \"**/*.{md,yml,yaml}\"",
         "clean": "rimraf dist",
@@ -102,10 +102,9 @@
         "which": "^5.0.0"
     },
     "devDependencies": {
-        "@apify/eslint-config": "^0.4.0",
-        "@apify/eslint-config-ts": "^0.4.1",
-        "@apify/tsconfig": "^0.1.0",
-        "@biomejs/biome": "^1.8.3",
+        "@apify/eslint-config": "^1.0.0",
+        "@apify/tsconfig": "^0.1.1",
+        "@biomejs/biome": "^1.9.4",
         "@crawlee/types": "^3.11.1",
         "@cucumber/cucumber": "^11.0.0",
         "@oclif/test": "^4.0.8",
@@ -124,21 +123,20 @@
         "@types/node": "^22.0.0",
         "@types/semver": "^7.5.8",
         "@types/which": "^3.0.4",
-        "@typescript-eslint/eslint-plugin": "^7.0.2",
-        "@typescript-eslint/parser": "^7.0.2",
         "@yarnpkg/core": "^4.1.2",
         "apify": "^3.2.4",
         "chai": "^4.4.1",
         "cross-env": "^7.0.3",
-        "eslint": "^8.57.0",
-        "eslint-config-prettier": "^10.0.0",
-        "lint-staged": "^15.2.8",
+        "eslint": "^9.25.1",
+        "eslint-config-prettier": "^10.1.2",
+        "lint-staged": "^15.5.1",
         "mdast-util-from-markdown": "^2.0.2",
         "mock-stdin": "^1.0.0",
         "oclif": "^4.14.15",
-        "prettier": "^3.3.3",
+        "prettier": "^3.5.3",
         "tsx": "^4.16.5",
-        "typescript": "^5.5.4",
+        "typescript": "^5.8.3",
+        "typescript-eslint": "^8.31.0",
         "vitest": "^3.0.0"
     },
     "oclif": {

package.json

@@ -21,6 +21,12 @@
 			"groupSlug": "all-non-major",
 			"automerge": true,
 			"automergeType": "branch"
+		},
+		{
+			"groupName": "eslint/prettier/biome",
+			"automerge": true,
+			"groupSlug": "formatting-linting-dependencies",
+			"matchPackageNames": ["/eslint/", "/prettier/", "/biome/"]
 		}
 	],
 	"schedule": ["every weekday"]

renovate.json

@@ -1,6 +1,7 @@
-import { APIFY_ENV_VARS } from '@apify/consts';
 import { Args, Flags } from '@oclif/core';
 
+import { APIFY_ENV_VARS } from '@apify/consts';
+
 import { getApifyTokenFromEnvOrAuthFile } from '../../lib/actor.js';
 import { ApifyCommand } from '../../lib/apify_command.js';
 import { info } from '../../lib/outputs.js';

src/commands/actor/charge.ts

@@ -1,6 +1,7 @@
+import { Args } from '@oclif/core';
+
 import { ACTOR_ENV_VARS, APIFY_ENV_VARS } from '@apify/consts';
 import { createHmacSignature } from '@apify/utilities';
-import { Args } from '@oclif/core';
 
 import { getApifyStorageClient } from '../../lib/actor.js';
 import { ApifyCommand } from '../../lib/apify_command.js';

src/commands/actor/get-public-url.ts

@@ -13,7 +13,7 @@ import chalk from 'chalk';
 
 import { ApifyCommand } from '../../lib/apify_command.js';
 import { getInputOverride } from '../../lib/commands/resolve-input.js';
-import { SharedRunOnCloudFlags, runActorOrTaskOnCloud } from '../../lib/commands/run-on-cloud.js';
+import { runActorOrTaskOnCloud, SharedRunOnCloudFlags } from '../../lib/commands/run-on-cloud.js';
 import { CommandExitCodes, LOCAL_CONFIG_PATH } from '../../lib/consts.js';
 import { error, simpleLog } from '../../lib/outputs.js';
 import { getLocalConfig, getLocalUserInfo, getLoggedClientOrThrow, TimestampFormatter } from '../../lib/utils.js';
@@ -222,7 +222,9 @@ export class ActorsCallCommand extends ApifyCommand<typeof ActorsCallCommand> {
 					break;
 				}
 
-				await new Promise((resolve) => setTimeout(resolve, 250));
+				await new Promise((resolve) => {
+					setTimeout(resolve, 250);
+				});
 			} while (retries--);
 
 			const dataset = await apifyClient.dataset(datasetId).downloadItems(DownloadItemsFormat.JSON, {

src/commands/actors/call.ts

@@ -1,9 +1,10 @@
-import type { ACTOR_JOB_STATUSES } from '@apify/consts';
 import { Flags } from '@oclif/core';
 import { Time } from '@sapphire/duration';
 import type { Actor, ActorRunListItem, ActorTaggedBuild, PaginatedList } from 'apify-client';
 import chalk from 'chalk';
 
+import type { ACTOR_JOB_STATUSES } from '@apify/consts';
+
 import { ApifyCommand } from '../../lib/apify_command.js';
 import { prettyPrintStatus } from '../../lib/commands/pretty-print-status.js';
 import { CompactMode, kSkipColumn, ResponsiveTable } from '../../lib/commands/responsive-table.js';