chore: Align storage collection types (#805)

### Description
- Add `username?: string;` for each collection item
- Add `& {unnamed: boolean;}` for each `...CollectionClientListResult`

Previously, `...CollectionClientListResult` types were inconsistent. Now
they are consistently `PaginatedList<StorageType> & {unnamed:
boolean;};`

### Issues
Closes: #796

Author: Pijukatel

src/resource_clients/dataset.ts

@@ -235,6 +235,7 @@ export interface Dataset {
     name?: string;
     title?: string;
     userId: string;
+    username?: string;
     createdAt: Date;
     modifiedAt: Date;
     accessedAt: Date;

src/resource_clients/dataset_collection.ts

@@ -2,7 +2,7 @@ import ow from 'ow';
 
 import type { ApiClientSubResourceOptions } from '../base/api_client';
 import { ResourceCollectionClient } from '../base/resource_collection_client';
-import type { PaginatedIterator, PaginatedList, PaginationOptions } from '../utils';
+import type { PaginatedList, PaginationOptions } from '../utils';
 import type { Dataset } from './dataset';
 
 export class DatasetCollectionClient extends ResourceCollectionClient {
@@ -32,7 +32,9 @@ export class DatasetCollectionClient extends ResourceCollectionClient {
      * for await (const singleItem of client.list(options)) {...}
      * ```
      */
-    list(options: DatasetCollectionClientListOptions = {}): PaginatedIterator<Dataset> {
+    list(
+        options: DatasetCollectionClientListOptions = {},
+    ): Promise<DatasetCollectionClientListResult> & AsyncIterable<Dataset> {
         ow(
             options,
             ow.object.exactShape({
@@ -66,4 +68,4 @@ export interface DatasetCollectionClientGetOrCreateOptions {
     schema?: Record<string, unknown>;
 }
 
-export type DatasetCollectionClientListResult = PaginatedList<Dataset>;
+export type DatasetCollectionClientListResult = PaginatedList<Dataset> & { unnamed: boolean };

src/resource_clients/key_value_store.ts

@@ -328,6 +328,7 @@ export interface KeyValueStore {
     name?: string;
     title?: string;
     userId: string;
+    username?: string;
     createdAt: Date;
     modifiedAt: Date;
     accessedAt: Date;

src/resource_clients/key_value_store_collection.ts

@@ -34,7 +34,7 @@ export class KeyValueStoreCollectionClient extends ResourceCollectionClient {
      */
     list(
         options: KeyValueStoreCollectionClientListOptions = {},
-    ): Promise<PaginatedList<KeyValueStoreCollectionListResult>> & AsyncIterable<KeyValueStore> {
+    ): Promise<KeyValueStoreCollectionListResult> & AsyncIterable<KeyValueStore> {
         ow(
             options,
             ow.object.exactShape({
@@ -71,4 +71,4 @@ export interface KeyValueStoreCollectionClientGetOrCreateOptions {
     schema?: Record<string, unknown>;
 }
 
-export type KeyValueStoreCollectionListResult = Omit<KeyValueStore, 'stats'> & { username?: string };
+export type KeyValueStoreCollectionListResult = PaginatedList<KeyValueStore> & { unnamed: boolean };

src/resource_clients/request_queue.ts

@@ -558,6 +558,7 @@ export interface RequestQueue {
     name?: string;
     title?: string;
     userId: string;
+    username?: string;
     createdAt: Date;
     modifiedAt: Date;
     accessedAt: Date;

src/resource_clients/request_queue_collection.ts

@@ -63,6 +63,4 @@ export interface RequestQueueCollectionListOptions extends PaginationOptions {
     desc?: boolean;
 }
 
-export type RequestQueueCollectionListResult = PaginatedList<RequestQueue & { username?: string }> & {
-    unnamed: boolean;
-};
+export type RequestQueueCollectionListResult = PaginatedList<RequestQueue> & { unnamed: boolean };