fix: KV store createKeysPublicUrl wrong URL (#724)

After release of new methods `KeyValueStore.createKeysPublicUrl` and
`Dataset.createItemsPublicUrl` ([PR
here](#720)), I noticed
that in `KeyValueStore.createKeysPublicUrl` I used incorrect path
`items` instead of `keys`.

This PR fixes URL path and improves tests.

Author: danpoletaev

src/resource_clients/key_value_store.ts

@@ -96,7 +96,6 @@ export class KeyValueStoreClient extends ResourceClient {
      * If not provided, the URL will not expire.
      *
      * Any other options (like `limit` or `prefix`) will be included as query parameters in the URL.
-     *
      */
     async createKeysPublicUrl(options: KeyValueClientListKeysOptions = {}, expiresInMillis?: number) {
         ow(
@@ -111,7 +110,7 @@ export class KeyValueStoreClient extends ResourceClient {
 
         const store = await this.get();
 
-        let createdPublicKeysUrl = new URL(this._url('items'));
+        let createdPublicKeysUrl = new URL(this._url('keys'));
 
         if (store?.urlSigningSecretKey) {
             const signature = createStorageContentSignature({

test/datasets.test.js

@@ -333,14 +333,18 @@ describe('Dataset methods', () => {
                 const datasetId = 'id-with-secret-key';
                 const res = await client.dataset(datasetId).createItemsPublicUrl();
 
-                expect(new URL(res).searchParams.get('signature')).toBeDefined();
+                const url = new URL(res);
+                expect(url.searchParams.get('signature')).toBeDefined();
+                expect(url.pathname).toBe(`/v2/datasets/${datasetId}/items`);
             });
 
             it('should not include a signature in the URL when the caller lacks permission to access the signing secret key', async () => {
                 const datasetId = 'some-id';
                 const res = await client.dataset(datasetId).createItemsPublicUrl();
 
-                expect(new URL(res).searchParams.get('signature')).toBeNull();
+                const url = new URL(res);
+                expect(url.searchParams.get('signature')).toBeNull();
+                expect(url.pathname).toBe(`/v2/datasets/${datasetId}/items`);
             });
 
             it('includes provided options (e.g., limit and prefix) as query parameters', async () => {
@@ -352,6 +356,7 @@ describe('Dataset methods', () => {
                 expect(itemsPublicUrl.searchParams.get('limit')).toBe('10');
                 expect(itemsPublicUrl.searchParams.get('offset')).toBe('5');
                 expect(itemsPublicUrl.searchParams.get('signature')).toBeDefined();
+                expect(itemsPublicUrl.pathname).toBe(`/v2/datasets/${datasetId}/items`);
             });
         });
     });

test/key_value_stores.test.js

@@ -559,14 +559,18 @@ describe('Key-Value Store methods', () => {
                 const storeId = 'id-with-secret-key';
                 const res = await client.keyValueStore(storeId).createKeysPublicUrl();
 
-                expect(new URL(res).searchParams.get('signature')).toBeDefined();
+                const url = new URL(res);
+                expect(url.searchParams.get('signature')).toBeDefined();
+                expect(url.pathname).toBe(`/v2/key-value-stores/${storeId}/keys`);
             });
 
             it('should not include a signature in the URL when the caller lacks permission to access the signing secret key', async () => {
                 const storeId = 'some-id';
                 const res = await client.keyValueStore(storeId).createKeysPublicUrl();
 
-                expect(new URL(res).searchParams.get('signature')).toBeNull();
+                const url = new URL(res);
+                expect(url.searchParams.get('signature')).toBeNull();
+                expect(url.pathname).toBe(`/v2/key-value-stores/${storeId}/keys`);
             });
 
             it('includes provided options (e.g., limit and prefix) as query parameters', async () => {
@@ -577,6 +581,7 @@ describe('Key-Value Store methods', () => {
                 expect(keysPublicUrl.searchParams.get('limit')).toBe('10');
                 expect(keysPublicUrl.searchParams.get('prefix')).toBe('prefix');
                 expect(keysPublicUrl.searchParams.get('signature')).toBeDefined();
+                expect(keysPublicUrl.pathname).toBe(`/v2/key-value-stores/${storeId}/keys`);
             });
         });
     });