list to dict

Author: Mantisus

src/apify_client/_statistics.py

@@ -1,3 +1,4 @@
+from collections import defaultdict
 from dataclasses import dataclass, field
 
 
@@ -11,7 +12,7 @@ class Statistics:
     requests: int = 0
     """Total number of HTTP requests sent, including retries."""
 
-    rate_limit_errors: list[int] = field(default_factory=list)
+    rate_limit_errors: defaultdict[int, int] = field(default_factory=lambda: defaultdict(int))
     """List tracking which retry attempts encountered rate limit (429) errors."""
 
     def add_rate_limit_error(self, attempt: int) -> None:
@@ -23,15 +24,4 @@ def add_rate_limit_error(self, attempt: int) -> None:
         if attempt < 1:
             raise ValueError('Attempt must be greater than 0')
 
-        index = attempt - 1
-        self._ensure_list_capacity(index)
-        self.rate_limit_errors[index] += 1
-
-    def _ensure_list_capacity(self, index: int) -> None:
-        """Ensure rate_limit_errors list has enough capacity.
-
-        Args:
-            index: Required index to access
-        """
-        if len(self.rate_limit_errors) <= index:
-            self.rate_limit_errors.extend([0] * (index - len(self.rate_limit_errors) + 1))
+        self.rate_limit_errors[attempt - 1] += 1

tests/unit/test_statistics.py

@@ -6,12 +6,12 @@
 @pytest.mark.parametrize(
     ('attempts', 'expected_errors'),
     [
-        ([1], [1]),
-        ([1, 5], [1, 0, 0, 0, 1]),
-        ([5, 1], [1, 0, 0, 0, 1]),
-        ([3, 5, 1], [1, 0, 1, 0, 1]),
-        ([1, 5, 3], [1, 0, 1, 0, 1]),
-        ([2, 1, 2, 1, 5, 2, 1], [3, 3, 0, 0, 1]),
+        ([1], {0: 1}),
+        ([1, 5], {0: 1, 4: 1}),
+        ([5, 1], {0: 1, 4: 1}),
+        ([3, 5, 1], {0: 1, 2: 1, 4: 1}),
+        ([1, 5, 3], {0: 1, 2: 1, 4: 1}),
+        ([2, 1, 2, 1, 5, 2, 1], {0: 3, 1: 3, 4: 1}),
     ],
     ids=[
         'single_error',
@@ -42,7 +42,7 @@ def test_statistics_initial_state() -> None:
     stats = Statistics()
     assert stats.calls == 0
     assert stats.requests == 0
-    assert stats.rate_limit_errors == []
+    assert stats.rate_limit_errors == {}
 
 
 def test_add_rate_limit_error_type_validation() -> None: