fix: revert details component rendering to pre-v3 state #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-tooling
|
Also, the chevron on the left (inside the blue box) doesn't seem to be the right size and position... Maybe yet another
|
honzajavorek
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Can't really comment on the React part, but from a manual tester's POV it all LGTM. I checked out the branch and locally I can see the details fixed. I can also see the arrow not aligned ideally (Firefox @ macOS), but let's ship it, as it is a clear improvement over the current state. Thanks for tackling this! It's important for the Python course ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the mismatch between the
<details>element pre- and post- the Docusaurus v3 update. Caused by Docusaurus expecting (some?) MDX component names being capitalized.Closes #1199