fix(request-queue): Update request queue locking docs #1322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-core-services
fnesveda
requested changes
Dec 9, 2024
Member
fnesveda
left a comment
fnesveda
left a comment
There was a problem hiding this comment.
Looks good, but the variable naming is a bit confusing, could you improve it?
Comment on lines
475
to
476
| const theFirstRequestLockedByClientOne = processingRequestsClientOne.items[0]; | ||
| const requestLockedByClientOne = await requestQueueClientOne.getRequest( |
Member
There was a problem hiding this comment.
The naming of these two variables is pretty confusing, I don't really know what's the difference between theFirstRequestLockedByClientOne and requestLockedByClientOne, especially by name. Could you come up with some better names?
| const theFirstRequestLockedByClientOne = processingRequestsClientOne.items[0]; | ||
| const requestLockedByClientOne = await requestQueueClientOne.getRequest( | ||
| theFirstRequestLockedByClientOne.id, | ||
| const wasTheClientTwoLockedSameRequest = !!processingRequestsClientTwo.items.find( |
Member
There was a problem hiding this comment.
Here I'm also not sure what the varaible means, could you rename it, or explain better in the comment?
drobnikj
changed the title
fnesveda
approved these changes
Dec 9, 2024
TC-MO
requested changes
Dec 10, 2024
Co-authored-by: Michał Olender <[email protected]>
TC-MO
approved these changes
Dec 10, 2024
fnesveda
added
the
validated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some changes in docs regarding the API changes.