Skip to content

Conversation

@drobnikj
Copy link
Member

@drobnikj drobnikj commented Jan 7, 2025

Address several issue and missing part in documentation.

@drobnikj drobnikj requested a review from TC-MO as a code owner January 7, 2025 09:48
@github-actions github-actions bot added this to the 106th sprint - Platform team milestone Jan 7, 2025
@github-actions github-actions bot added the t-core-services Issues with this label are in the ownership of the core services team. label Jan 7, 2025
@drobnikj drobnikj requested a review from Copilot January 7, 2025 10:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (4)

sources/platform/integrations/workflows-and-notifications/make.md:22

  • The heading 'Add the Apify module to scenario' should be 'Add the Apify module to your scenario' for consistency.
### Add the Apify module to scenario

sources/platform/integrations/workflows-and-notifications/make.md:52

  • The phrase 'Make.com imposes a hard timeout of 5 minutes for synchronous runs' should be 'Make imposes a hard timeout of 5 minutes for synchronous runs' for consistency.
Make.com imposes a hard timeout of 5 minutes for synchronous runs.

sources/platform/integrations/workflows-and-notifications/make.md:69

  • The phrase 'so the module waits for the Actor to finish run' should be 'so the module waits for the Actor to finish running' for correct grammar.
Make sure to set the 'Run synchronously' option to 'Yes,' so the module waits for the Actor to finish run.

sources/platform/integrations/workflows-and-notifications/make.md:84

  • The phrase 'Google Sheets 'Bulk Add Rows' module' should be 'Google Sheets 'Create Spreadsheet Rows' module' for consistency with the module name.
Finally, add the Google Sheets 'Bulk Add Rows' module to your scenario.

@drobnikj drobnikj requested a review from fnesveda January 7, 2025 10:01
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! A lot better than before 👍

Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few comments & suggestions

@drobnikj drobnikj merged commit 0d8b853 into master Jan 10, 2025
8 checks passed
@drobnikj drobnikj deleted the feat/update-make-com-docs branch January 10, 2025 15:37
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-core-services Issues with this label are in the ownership of the core services team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants