Skip to content

feat: update the Getting Links lesson to be about JS #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2025
Merged

feat: update the Getting Links lesson to be about JS #1740

merged 2 commits into from
Aug 5, 2025

Conversation

@honzajavorek
Copy link
Collaborator

@honzajavorek honzajavorek commented Jul 30, 2025

A part of #1584

@honzajavorek honzajavorek requested review from TC-MO and gullmar July 30, 2025 10:07
@honzajavorek honzajavorek added the t-academy Issues related to Web Scraping and Apify academies. label Jul 30, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view

@apify-service-account
Copy link

apify-service-account commented Jul 30, 2025

Preview for this PR was built for commit 1cfed3f and is ready at https://pr-1740.preview.docs.apify.com!

gullmar
gullmar reviewed Jul 31, 2025
View reviewed changes
@apify-service-account
Copy link

apify-service-account commented Jul 31, 2025

Preview for this PR was built for commit cd7c963a and is ready at https://pr-1740.preview.docs.apify.com!

@honzajavorek
Copy link
Collaborator Author

honzajavorek commented Jul 31, 2025

@gullmar Thanks for suggesting for (const element of $("...").toArray()), I didn't think of such way to iterate over the Cheerio selections and I like it better. But I have many examples doing this throughout the whole course, so if you don't mind, I'll try to avoid merge conflict hell and I'll change it in all the course at once.

I cut these small PRs out of this beast #1584, so I'll add a commit to that one where I change all the iterations throughout the JS course.

@gullmar
Copy link
Contributor

gullmar commented Jul 31, 2025

Yeah, no problem, I did not know that there were many instances of that. 🙂

@honzajavorek
Copy link
Collaborator Author

honzajavorek commented Jul 31, 2025

Addressed the loops in 4ea16ba for now.

@honzajavorek
Copy link
Collaborator Author

honzajavorek commented Jul 31, 2025

bugbot run

cursor[bot]
cursor bot reviewed Jul 31, 2025
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!

Comment bugbot run to trigger another review on this PR

@honzajavorek honzajavorek merged commit 8d0b8bc into master Aug 5, 2025
10 checks passed
@honzajavorek honzajavorek deleted the honzajavorek/js2-getting-links branch August 5, 2025 09:00
daveomri pushed a commit to daveomri/apify-docs that referenced this pull request Sep 3, 2025
@honzajavorek @gullmar @daveomri
feat: update the Getting Links lesson to be about JS (apify#1740)
65105a8 
A part of apify#1584

---------

Co-authored-by: gullmar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@gullmar gullmar gullmar approved these changes

@TC-MO TC-MO TC-MO approved these changes

Assignees

No one assigned

Labels

t-academy Issues related to Web Scraping and Apify academies.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@honzajavorek @apify-service-account @gullmar @TC-MO