fix: smithery, review comments

Author: jirispilka

package.json

@@ -7,7 +7,7 @@
     "node": ">=18.0.0"
   },
   "main": "dist/index.js",
-  "module": "./src/index.ts",
+  "module": "./src/smithery.ts",
   "exports": {
     ".": "./dist/index.js",
     "./internals": "./dist/index-internals.js",

src/index.ts

@@ -4,8 +4,3 @@
  The ActorsMcpServer should be the only class exported from the package
 */
 export { ActorsMcpServer } from './mcp/server.js';
-
-// Uncomment the following lines if you want run the server using: npx @smithery/cli build && npx @smithery/cli dev
-// export { serverConfigSchemaSmithery as configSchema } from './types.js';
-// export { default as smithery } from './smithery.js';
-

src/mcp/server.ts

@@ -104,7 +104,7 @@ export class ActorsMcpServer {
      */
     public blockListToolsUntil(promise: Promise<unknown>, timeoutMs = 8_000) {
         const done = Promise.resolve(promise).then(() => undefined).catch(() => undefined);
-        const timeout = new Promise<void>((resolve) => setTimeout(resolve, timeoutMs));
+        const timeout = new Promise<void>((resolve) => { setTimeout(resolve, timeoutMs); });
         this.listToolsBarrier = Promise.race([done, timeout]).then(() => undefined);
     }
 

src/smithery.ts

@@ -7,28 +7,28 @@
 */
 import type { z } from 'zod';
 
+import { PLACEHOLDER_APIFY_TOKEN } from './const.js';
 import { ActorsMcpServer } from './mcp/server.js';
 import type { Input, ToolCategory } from './types';
 import { serverConfigSchemaSmithery as configSchema } from './types.js';
 import { loadToolsFromInput } from './utils/tools-loader.js';
-import { PLACEHOLDER_APIFY_TOKEN } from './const.js';
 
 // Export the config schema for Smithery. The export must be named configSchema
 export { configSchema };
 
 /**
- * Main entrypoint for Smithery deployment do not change signature of this function.
+ * The Main entrypoint for Smithery deployment do not change signature of this function.
  * @returns
  */
+// eslint-disable-next-line import/no-default-export
 export default function ({ config: _config }: { config: z.infer<typeof configSchema> }) {
     try {
-        let apifyToken = _config.apifyToken || process.env.APIFY_TOKEN || '';
+        const apifyToken = _config.apifyToken || process.env.APIFY_TOKEN || '';
         const enableAddingActors = _config.enableAddingActors ?? true;
         const actors = _config.actors || '';
         const actorList = actors ? actors.split(',').map((a: string) => a.trim()) : [];
         const toolCategoryKeys = _config.tools ? _config.tools.split(',').map((t: string) => t.trim()) : [];
 
-        console.log(`Apify token ${apifyToken}`)
         process.env.APIFY_TOKEN = apifyToken; // Ensure token is set in the environment
         const server = new ActorsMcpServer({ enableAddingActors, enableDefaultActors: false });
 
@@ -58,7 +58,6 @@ export default function ({ config: _config }: { config: z.infer<typeof configSch
         })();
         server.blockListToolsUntil(loadPromise);
         return server.server;
-
     } catch (e) {
         // eslint-disable-next-line no-console
         console.error(e);

tests/unit/smithery.test.ts

@@ -2,9 +2,9 @@ import { beforeEach, describe, expect, it, vi } from 'vitest';
 
 import log from '@apify/log';
 
-import * as toolsLoader from '../../src/utils/tools-loader.js';
 import { ActorsMcpServer } from '../../src/mcp/server.js';
 import smithery from '../../src/smithery.js';
+import * as toolsLoader from '../../src/utils/tools-loader.js';
 
 // Silence logs in unit tests
 log.setLevel(log.LEVELS.OFF);
@@ -16,11 +16,11 @@ describe('smithery entrypoint barrier behavior', () => {
 
     it('calls blockListToolsUntil', async () => {
         // Arrange
-        const blockSpy = vi.spyOn(ActorsMcpServer.prototype as any, 'blockListToolsUntil');
+        const blockSpy = vi.spyOn(ActorsMcpServer.prototype, 'blockListToolsUntil');
         const loadSpy = vi.spyOn(toolsLoader, 'loadToolsFromInput').mockResolvedValue([]);
 
         // Act
-        const server = smithery({ config: { apifyToken: 'TEST_TOKEN', enableAddingActors: true } as any });
+        const server = smithery({ config: { apifyToken: 'TEST_TOKEN', enableAddingActors: true } });
 
         // Assert
         expect(server).toBeTruthy();