feat(input): allow empty tools and actors to allow greater control of exposed tools #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-ai
MichalKalita
suggested changes
Aug 18, 2025
MichalKalita
approved these changes
Aug 19, 2025
Collaborator
|
We’ll need to create a new PR or incorporate all the changes we discussed with Honza. |
Contributor
Author
I would be for creating a new PR and either base it from this branch or merge it into this branch where we would also refactor/simplify the whole input/parameter handling. I agree, that we should include everything in a one PR/release. |
* feat: refactor and unify input handling, remove unnecessary logic * feat: vibe new mcp input spec * fix: remove unnecessary addTool in mcp/server.ts * fix: fix stdio.only add-actor tool related circular dependency cause by import of getActorsAsTools and pass it as internal tool arg instead. * fix test suite, clean up * fix tests and logic to adhere to the new spec * refactor code * lint * rename to fetch-actor-details * improve readme * update stdio help * improve test case names * fix and improve the call-actor generic tool * more spec new spec complience tests * lint * one more test, just in case * address pr comment and refactor the process input func * fix: Delete example clients, update Readme (#239) fix: Delete clients (in examples). They are not used and outdated anyway. Also update README.md * Update tests/unit/input.test.ts Co-authored-by: Jiří Spilka <[email protected]> * Update tests/unit/input.test.ts Co-authored-by: Jiří Spilka <[email protected]> * Update README.md Co-authored-by: Jiří Spilka <[email protected]> * address review comments * clean up imports and update comments for clarity, export functions for internal repo --------- Co-authored-by: Jiří Spilka <[email protected]>
MichalKalita
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #214
also handles this feature request https://console.apify.com/actors/1lSvMAaRcadrM1Vgv/issues/uMIkLfBQgw1hy8M95
Currently, default tools (Actor details, search, and add Actor — unless explicitly disabled via
enableAddingActors) anddocscategory tools are always enabled and cannot be disabled. This is poor UX — some users may want access only to docs and not call Actors, or may want access to just a single Actor without any other tools.This PR addresses that. When the user does not specify any parameters (e.g.,
?actorsor?tools), the default tools are loaded as specified in the README. However, if the user specifies, for example,tools=storage, only thestoragetools category will be loaded, along with theadd-actortool and the default RAG web browser Actor — both of which can also be disabled if needed.With this change, users can disable all Actors and tools entirely by setting parameters to empty values, such as
?actors=&tools=&enableAddingActors=false. This configuration would expose no tools from the MCP server, rendering it effectively useless — but it demonstrates the fine-grained control now available.tools=storagebut still expectdocstools to be available (since they're currently loaded by default). While this is a potentially "breaking" change, we should consider it minor. Users should explicitly list the tool categories they actively use and avoid relying on implicit defaults in production workflows.