Skip to content

Conversation

@MQ37
Copy link
Contributor

@MQ37 MQ37 commented Aug 20, 2025

In order to publish the server to dockerhub it needs to be able to pass their build task. This task build the docker image and starts the container with the server and tries to list the tools, which Apify server was failing at because of the dummy token passed where the Apify API was throwing an error. Changed the logic to delete the dummy token and use the API as unauth which is sufficient for loading the Actor tools and listing.

@github-actions github-actions bot added the t-ai Issues owned by the AI team. label Aug 20, 2025
@MQ37 MQ37 requested a review from jirispilka August 20, 2025 08:07
Copy link
Collaborator

@jirispilka jirispilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is really a hack, should we keep the token empty in the docker?

So that we would remove it only when empty, and we don't have to check for a specific value

@MQ37
Copy link
Contributor Author

MQ37 commented Aug 20, 2025

Well, this is really a hack, should we keep the token empty in the docker?

So that we would remove it only when empty, and we don't have to check for a specific value

In the dockerhub server.yaml it is defined as:

    secrets:
        - name: apify-mcp-server.apify_token
          env: APIFY_TOKEN
          example: your-apify-token

I would keep this logic. Since now it will work for dokerhub and we can also keep the behaviour for users that execute the CLI without (or with empty) token and print the error message that they need to set the token.

@MQ37 MQ37 merged commit 87b2f2c into master Aug 20, 2025
4 checks passed
@MQ37 MQ37 deleted the fix/dockerhub-list-no-token branch August 20, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ai Issues owned by the AI team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants