Skip to content

Conversation

@jirispilka
Copy link
Collaborator

@jirispilka jirispilka commented Nov 20, 2025

  • feat: Remove old code used for Actor

@github-actions github-actions bot added t-ai Issues owned by the AI team. tested Temporary label used only programatically for some analytics. labels Nov 20, 2025
@jirispilka jirispilka force-pushed the feat/remove-actor-code branch from c37cec5 to 04e6a17 Compare November 26, 2025 11:16
@jirispilka jirispilka requested a review from MQ37 November 26, 2025 11:29
Copy link
Contributor

@MQ37 MQ37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests in the suite.ts are using the apify/actors-mcp-server (also stored in the ACTOR_MCP_SERVER_ACTOR_NAME const) - be sure to mark these tests using skip() so they are skipped.

We should also prioritize moving most of the web server logic to this public repo and make it somehow extensible for the internal one (for rate limitting, mongo access, ...). Also we should rework the testing suite and make it more robust since we wont be able to deploy this Actor required for testing as it will be removed - I was thinking about this for some time, I think we should make a set of few simple testing Actors in this repo and the test suite should automatically push that to the platform for the test run and clean up after.

@jirispilka
Copy link
Collaborator Author

ACTOR_MCP_SERVER_ACTOR_NAME

The tests in the suite.ts are using the apify/actors-mcp-server (also stored in the ACTOR_MCP_SERVER_ACTOR_NAME const) - be sure to mark these tests using skip() so they are skipped.

oh 🤦🏻 . I didn't realize that we are using the apify/actors-mcp-server Actor for tests.

What should have done is to move the actor dependencies into dev dependencies and keep the http server in tests, I guess.

Also we should rework the testing suite and make it more robust since we wont be able to deploy this Actor required for testing as it will be removed - I was thinking about this for some time, I think we should make a set of few simple testing Actors in this repo and the test suite should automatically push that to the platform for the test run and clean up after.

Considering this. I think it could be even one simple Actor (combination of normal Actor + timeout, standby Actor) that we can use for testing.

And the Actor will be part of the public repo (it would be in tests, dependencies for Actor will be in dev dep so the prod code would be clean)

@jirispilka
Copy link
Collaborator Author

We need to redo test and also have a new Actor that we can use for testing. Closing it without merging.

@jirispilka jirispilka closed this Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ai Issues owned by the AI team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants