unit - scrapy utils

Author: vdusek

tests/unit/scrapy/utils/test_apply_apify_settings.py

@@ -5,14 +5,14 @@
 from apify.scrapy.utils import apply_apify_settings
 
 
-def test__apply_apify_settings__overrides_scheduler() -> None:
+def test_overrides_scheduler() -> None:
     settings = Settings()
     new_settings = apply_apify_settings(settings=settings)
 
     assert new_settings.get('SCHEDULER') == 'apify.scrapy.scheduler.ApifyScheduler'
 
 
-def test__apply_apify_settings__update_item_pipelines() -> None:
+def test_updates_item_pipelines() -> None:
     settings = Settings(
         {
             'ITEM_PIPELINES': {
@@ -28,7 +28,7 @@ def test__apply_apify_settings__update_item_pipelines() -> None:
     }
 
 
-def test__apply_apify_settings__update_downloader_middlewares() -> None:
+def test_updates_downloader_middlewares() -> None:
     settings = Settings(
         {
             'DOWNLOADER_MIDDLEWARES': {
@@ -49,7 +49,7 @@ def test__apply_apify_settings__update_downloader_middlewares() -> None:
     }
 
 
-def test__apply_apify_settings__add_proxy_config() -> None:
+def test_adds_proxy_config() -> None:
     settings = Settings()
     new_settings = apply_apify_settings(settings=settings)
     assert new_settings.get('APIFY_PROXY_SETTINGS') is None

tests/unit/scrapy/utils/test_get_basic_auth_header.py

@@ -14,13 +14,14 @@ class TestCase:
     expected_auth_header: bytes
 
 
-test_cases = [
-    TestCase('username', 'password', b'Basic dXNlcm5hbWU6cGFzc3dvcmQ='),
-    TestCase('john_smith', 'secret_password_123', b'Basic am9obl9zbWl0aDpzZWNyZXRfcGFzc3dvcmRfMTIz'),
-]
-
-
-@pytest.mark.parametrize('tc', test_cases)
-def test__get_basic_auth_header(tc: TestCase) -> None:
+@pytest.mark.parametrize(
+    'tc',
+    [
+        TestCase('username', 'password', b'Basic dXNlcm5hbWU6cGFzc3dvcmQ='),
+        TestCase('john_smith', 'secret_password_123', b'Basic am9obl9zbWl0aDpzZWNyZXRfcGFzc3dvcmRfMTIz'),
+    ],
+    ids=['simple_username_password', 'complex_username_password'],
+)
+def test_basic_auth_header_generation(tc: TestCase) -> None:
     auth_header = get_basic_auth_header(tc.username, tc.password)
     assert auth_header == tc.expected_auth_header