chore: updated test_generate_public_url_for_kvs_record test

Author: danpoletaev

src/apify/apify_storage_client/_key_value_store_client.py

@@ -7,8 +7,8 @@
 
 from crawlee.storage_clients._base import KeyValueStoreClient as BaseKeyValueStoreClient
 from crawlee.storage_clients.models import KeyValueStoreListKeysPage, KeyValueStoreMetadata, KeyValueStoreRecord
-from apify._crypto import (create_hmac_signature)
 
+from apify._crypto import create_hmac_signature
 
 if TYPE_CHECKING:
     from collections.abc import AsyncIterator
@@ -94,7 +94,8 @@ async def get_public_url(self, key: str) -> str:
         public_api_url = self._api_public_base_url
         public_url = f'{public_api_url}/v2/key-value-stores/{self._client.resource_id}/records/{key}'
 
-        if getattr(self.storage_object, 'url_signing_secret_key', None):
-            public_url += f'?signature={create_hmac_signature(self.storage_object.url_signing_secret_key, key)}'
+        url_signing_secret_key = getattr(self.storage_object, 'url_signing_secret_key', None)  # type: ignore[attr-defined]
+        if url_signing_secret_key:
+            public_url += f'?signature={create_hmac_signature(url_signing_secret_key, key)}'
 
-        return public_url
+        return public_url

tests/integration/test_actor_key_value_store.py

@@ -6,6 +6,7 @@
 
 from ._utils import generate_unique_resource_name
 from apify import Actor
+from apify._crypto import create_hmac_signature
 
 if TYPE_CHECKING:
     import pytest
@@ -210,10 +211,16 @@ async def main() -> None:
             default_store_id = Actor.config.default_key_value_store_id
 
             store = await Actor.open_key_value_store()
-            record_url = await cast(KeyValueStoreClient, store._resource_client).get_public_url('dummy')
-            print(record_url)
-
-            assert record_url == f'{public_api_url}/v2/key-value-stores/{default_store_id}/records/dummy'
+            record_key = 'dummy'
+            record_url = await cast(KeyValueStoreClient, store._resource_client).get_public_url(record_key)
+            url_signing_secret_key = cast(str, getattr(store.storage_object, 'url_signing_secret_key', None))
+            signature = create_hmac_signature(url_signing_secret_key, record_key)
+
+            assert url_signing_secret_key is not None
+            assert (
+                record_url
+                == f'{public_api_url}/v2/key-value-stores/{default_store_id}/records/{record_key}?signature={signature}'
+            )
 
     actor = await make_actor(label='kvs-get-public-url', main_func=main)
     run_result = await run_actor(actor)