address feedback

Author: vdusek

docs/02_concepts/code/01_class_manual.py

@@ -6,18 +6,20 @@
 async def main() -> None:
     await Actor.init()
 
-    # Get input
-    actor_input = await Actor.get_input()
-    Actor.log.info('Actor input: %s', actor_input)
+    try:
+        # Get input
+        actor_input = await Actor.get_input()
+        Actor.log.info('Actor input: %s', actor_input)
 
-    # Your Actor logic here
-    data = {'message': 'Hello from Actor!', 'input': actor_input}
-    await Actor.push_data(data)
+        # Your Actor logic here
+        data = {'message': 'Hello from Actor!', 'input': actor_input}
+        await Actor.push_data(data)
 
-    # Set status message
-    await Actor.set_status_message('Actor completed successfully')
+        # Set status message
+        await Actor.set_status_message('Actor completed successfully')
 
-    await Actor.exit()
+    finally:
+        await Actor.exit()
 
 
 if __name__ == '__main__':

docs/02_concepts/code/01_instance_context.py

@@ -20,7 +20,7 @@ async def main() -> None:
         await actor.push_data(data)
 
         # Set status message
-        await Actor.set_status_message('Actor completed successfully')
+        await actor.set_status_message('Actor completed successfully')
 
 
 if __name__ == '__main__':

docs/02_concepts/code/01_instance_manual.py

@@ -12,18 +12,20 @@ async def main() -> None:
 
     await actor.init()
 
-    # Get input
-    actor_input = await actor.get_input()
-    actor.log.info('Actor input: %s', actor_input)
+    try:
+        # Get input
+        actor_input = await actor.get_input()
+        actor.log.info('Actor input: %s', actor_input)
 
-    # Your Actor logic here
-    data = {'message': 'Hello from Actor!', 'input': actor_input}
-    await actor.push_data(data)
+        # Your Actor logic here
+        data = {'message': 'Hello from Actor!', 'input': actor_input}
+        await actor.push_data(data)
 
-    # Set status message
-    await actor.set_status_message('Actor completed successfully')
+        # Set status message
+        await actor.set_status_message('Actor completed successfully')
 
-    await actor.exit()
+    finally:
+        await actor.exit()
 
 
 if __name__ == '__main__':

pyproject.toml

@@ -113,7 +113,6 @@ ignore = [
     "PLR0911",  # Too many return statements
     "PLR0913",  # Too many arguments in function definition
     "PLR0915",  # Too many statements
-    "PLR2004",  # Magic value used in comparison, consider replacing `0.2` with a constant variable
     "PTH",      # flake8-use-pathlib
     "PYI034",   # `__aenter__` methods in classes like `{name}` usually return `self` at runtime
     "PYI036",   # The second argument in `__aexit__` should be annotated with `object` or `BaseException | None`
@@ -153,6 +152,7 @@ indent-style = "space"
     "INP001",  # File {filename} is part of an implicit namespace package, add an __init__.py
     "F841",    # Local variable {variable} is assigned to but never used
     "TRY301",  # Abstract `raise` to an inner function
+    "PLR2004", # Magic value used in comparison, consider replacing `{value}` with a constant variable
     "PLW0603", # Using the global statement to update `{name}` is discouraged
 ]
 "**/docs/**/scrapy_project/**/__main__.py" = [

tests/integration/test_actor_lifecycle.py

@@ -2,8 +2,6 @@
 
 from typing import TYPE_CHECKING
 
-from apify_shared.consts import ActorExitCodes
-
 from apify import Actor
 
 if TYPE_CHECKING:
@@ -117,7 +115,7 @@ async def main() -> None:
     actor = await make_actor(label='with-actor-fail', main_func=main)
     run_result = await run_actor(actor)
 
-    assert run_result.exit_code == ActorExitCodes.ERROR_USER_FUNCTION_THREW.value
+    assert run_result.exit_code == 91
     assert run_result.status == 'FAILED'