Skip to content

Commit 47ddbd2

Browse files
committed
use pull request for code checks
1 parent f3ddd95 commit 47ddbd2

File tree

2 files changed

+15
-9
lines changed

2 files changed

+15
-9
lines changed

.github/workflows/run_code_checks.yaml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,16 @@ name: Run code checks
22

33
on:
44
# Trigger code checks on opening a new pull request.
5-
pull_request_target:
5+
# Secrets are only made available to the integration tests job, with a manual approval
6+
# step required for PRs from forks. This prevents their potential exposure.
7+
pull_request:
68

7-
# Do not trigger code checks on push to the master branch, as they will be triggered
8-
# by the release workflow.
9-
10-
# Trigger code checks on workflow call (e.g. from run release workflow).
11-
workflow_call:
9+
# Trigger code checks on pushing to the master branch.
10+
push:
11+
branches:
12+
- master
13+
tags-ignore:
14+
- "**"
1215

1316
jobs:
1417
lint_check:
@@ -39,5 +42,6 @@ jobs:
3942

4043
integration_tests:
4144
name: Integration tests
45+
needs: [lint_check, type_check, unit_tests, changelog_entry_check, version_conflict_check, docs_check]
4246
uses: apify/workflows/.github/workflows/python_integration_tests.yaml@main
4347
secrets: inherit

.github/workflows/run_release.yaml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
11
name: Run release
22

33
on:
4-
# Push to master will publish a beta version
4+
# Push to master will publish a beta version.
55
push:
66
branches:
77
- master
88
tags-ignore:
99
- "**"
10-
# A release via GitHub releases will publish a stable version
10+
11+
# A release via GitHub releases will publish a stable version.
1112
release:
1213
types: [published]
13-
# Workflow dispatch will publish whatever you choose
14+
15+
# Workflow dispatch will publish whatever you choose.
1416
workflow_dispatch:
1517
inputs:
1618
release_type:

0 commit comments

Comments
 (0)