Skip to content

Commit 78b35c2

Browse files
committed
address feedback & fixes
1 parent cc250f1 commit 78b35c2

File tree

4 files changed

+44
-73
lines changed

4 files changed

+44
-73
lines changed

.github/workflows/build_and_deploy_docs.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88

99
env:
1010
NODE_VERSION: 22
11-
PYTHON_VERSION: 3.12
11+
PYTHON_VERSION: 3.13
1212

1313
jobs:
1414
build_and_deploy_docs:
@@ -54,7 +54,7 @@ jobs:
5454
with:
5555
python-version: ${{ env.PYTHON_VERSION }}
5656

57-
- name: Install uv package manager
57+
- name: Set up uv package manager
5858
uses: astral-sh/setup-uv@v5
5959
with:
6060
python-version: ${{ env.PYTHON_VERSION }}

CONTRIBUTING.md

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -153,14 +153,8 @@ version = "x.z.y"
153153
uv build
154154
```
155155

156-
5. Set up the PyPI API token for authentication:
156+
5. Set up the PyPI API token for authentication and upload the package to PyPI:
157157

158158
```shell
159-
uv config pypi-token.pypi YOUR_API_TOKEN
160-
```
161-
162-
6. Upload the package to PyPI:
163-
164-
```shell
165-
uv publish
159+
uv publish --token YOUR_API_TOKEN
166160
```

pyproject.toml

Lines changed: 14 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
#########################
2-
# PEP 621 configuration #
3-
#########################
4-
51
[build-system]
62
requires = ["hatchling"]
73
build-backend = "hatchling.build"
@@ -40,7 +36,7 @@ keywords = [
4036
dependencies = [
4137
"apify-client>=1.9.2",
4238
"apify-shared>=1.2.1",
43-
"crawlee~=0.5.1",
39+
"crawlee~=0.5.0",
4440
"cryptography>=42.0.0",
4541
"httpx>=0.27.0",
4642
"lazy-object-proxy>=1.10.0",
@@ -50,7 +46,19 @@ dependencies = [
5046
# https://github.com/apify/apify-sdk-python/issues/325
5147
"websockets>=10.0,<14.0.0",
5248
]
49+
5350
[project.optional-dependencies]
51+
scrapy = ["scrapy>=2.11.0"]
52+
53+
[project.urls]
54+
"Homepage" = "https://docs.apify.com/sdk/python/"
55+
"Apify homepage" = "https://apify.com"
56+
"Changelog" = "https://docs.apify.com/sdk/python/docs/changelog"
57+
"Documentation" = "https://docs.apify.com/sdk/python/"
58+
"Issue tracker" = "https://github.com/apify/apify-sdk-python/issues"
59+
"Repository" = "https://github.com/apify/apify-sdk-python"
60+
61+
[dependency-groups]
5462
dev = [
5563
"build~=1.2.0",
5664
"filelock~=3.17.0",
@@ -68,27 +76,10 @@ dev = [
6876
"ruff~=0.9.0",
6977
"setuptools~=75.8.0", # setuptools are used by pytest but not explicitly required
7078
]
71-
scrapy = ["scrapy>=2.11.0"]
72-
73-
[project.urls]
74-
homepage = "https://docs.apify.com/sdk/python/"
75-
apify_homepage = "https://apify.com"
76-
changelog = "https://docs.apify.com/sdk/python/docs/changelog"
77-
documentation = "https://docs.apify.com/sdk/python/"
78-
issue_tracker = "https://github.com/apify/apify-sdk-python/issues"
79-
repository = "https://github.com/apify/apify-sdk-python"
80-
81-
#######################
82-
# Hatch configuration #
83-
#######################
8479

8580
[tool.hatch.build.targets.wheel]
8681
packages = ["src/apify"]
8782

88-
######################
89-
# Ruff configuration #
90-
######################
91-
9283
[tool.ruff]
9384
line-length = 120
9485
include = ["src/**/*.py", "tests/**/*.py", "docs/**/*.py", "website/**/*.py"]
@@ -185,20 +176,12 @@ known-first-party = ["apify_client", "apify_shared", "crawlee"]
185176
[tool.ruff.lint.pylint]
186177
max-branches = 18
187178

188-
########################
189-
# Pytest configuration #
190-
########################
191-
192179
[tool.pytest.ini_options]
193180
addopts = "-ra"
194181
asyncio_default_fixture_loop_scope = "function"
195182
asyncio_mode = "auto"
196183
timeout = 1200
197184

198-
######################
199-
# Mypy configuration #
200-
######################
201-
202185
[tool.mypy]
203186
python_version = "3.9"
204187
plugins = ["pydantic.mypy"]
@@ -226,25 +209,13 @@ module = [
226209
]
227210
ignore_missing_imports = true
228211

229-
##############################
230-
# BasedPyright configuration #
231-
##############################
232-
233212
[tool.basedpyright]
234213
pythonVersion = "3.9"
235214
typeCheckingMode = "standard"
236215
include = ["src", "tests", "docs", "website"]
237216

238-
##########################
239-
# Coverage configuration #
240-
##########################
241-
242217
[tool.coverage.report]
243218
exclude_lines = ["pragma: no cover", "if TYPE_CHECKING:", "assert_never()"]
244219

245-
######################
246-
# Ipdb configuration #
247-
######################
248-
249220
[tool.ipdb]
250-
context = 7
221+
context = 7

uv.lock

Lines changed: 26 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)