Remove some noqas thanks to new Ruff release (#172)

Author: vdusek

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## [1.5.2](../../releases/tag/v1.5.2) - Unreleased
 
+### Internal changes
+
+- Remove some noqas thanks to the new Ruff release
+
 ### Fixed
 
 - Add missing import check to `ApifyHttpProxyMiddleware`
@@ -11,7 +15,7 @@
 ### Internal changes
 
 - Allowed running integration tests from PRs from forks, after maintainer approval
-- Do not close `nested_event_loop` in the `Scheduler.__del__`.
+- Do not close `nested_event_loop` in the `Scheduler.__del__`
 
 ## [1.5.0](../../releases/tag/v1.5.0) - 2024-01-03
 

src/apify/_memory_storage/resource_clients/base_resource_collection_client.py

@@ -43,7 +43,7 @@ def _get_resource_client_class(self: BaseResourceCollectionClient) -> type[Resou
         raise NotImplementedError('You must override this method in the subclass!')
 
     @abstractmethod
-    async def list(self: BaseResourceCollectionClient) -> ListPage:  # noqa: A003
+    async def list(self: BaseResourceCollectionClient) -> ListPage:
         """List the available storages.
 
         Returns:

src/apify/_memory_storage/resource_clients/dataset.py

@@ -314,7 +314,7 @@ async def push_items(self: DatasetClient, items: JSONSerializable) -> None:
             existing_dataset_by_id._dataset_entries[idx] = entry
             added_ids.append(idx)
 
-        data_entries = [(id, existing_dataset_by_id._dataset_entries[id]) for id in added_ids] # noqa: A001
+        data_entries = [(id, existing_dataset_by_id._dataset_entries[id]) for id in added_ids]  # noqa: A001
 
         async with existing_dataset_by_id._file_operation_lock:
             await existing_dataset_by_id._update_timestamps(has_been_modified=True)

src/apify/_memory_storage/resource_clients/dataset_collection.py

@@ -21,7 +21,7 @@ def _get_storage_client_cache(self: DatasetCollectionClient) -> list[DatasetClie
     def _get_resource_client_class(self: DatasetCollectionClient) -> type[DatasetClient]:
         return DatasetClient
 
-    async def list(self: DatasetCollectionClient) -> ListPage:  # noqa: A003
+    async def list(self: DatasetCollectionClient) -> ListPage:
         """List the available datasets.
 
         Returns:

src/apify/_memory_storage/resource_clients/key_value_store_collection.py

@@ -21,7 +21,7 @@ def _get_storage_client_cache(self: KeyValueStoreCollectionClient) -> list[KeyVa
     def _get_resource_client_class(self: KeyValueStoreCollectionClient) -> type[KeyValueStoreClient]:
         return KeyValueStoreClient
 
-    async def list(self: KeyValueStoreCollectionClient) -> ListPage:  # noqa: A003
+    async def list(self: KeyValueStoreCollectionClient) -> ListPage:
         """List the available key-value stores.
 
         Returns:

src/apify/_memory_storage/resource_clients/request_queue_collection.py

@@ -21,7 +21,7 @@ def _get_storage_client_cache(self: RequestQueueCollectionClient) -> list[Reques
     def _get_resource_client_class(self: RequestQueueCollectionClient) -> type[RequestQueueClient]:
         return RequestQueueClient
 
-    async def list(self: RequestQueueCollectionClient) -> ListPage:  # noqa: A003
+    async def list(self: RequestQueueCollectionClient) -> ListPage:
         """List the available request queues.
 
         Returns:

src/apify/actor.py

@@ -295,7 +295,7 @@ async def _cancel_event_emitting_intervals(self: Actor) -> None:
                 await self._send_system_info_interval_task
 
     @classmethod
-    async def exit(  # noqa: A003
+    async def exit(
         cls: type[Actor],
         *,
         exit_code: int = 0,

src/apify/event_manager.py

@@ -219,7 +219,7 @@ async def _process_platform_messages(self: EventManager) -> None:
         try:
             async with websockets.client.connect(self._config.actor_events_ws_url) as websocket:
                 self._platform_events_websocket = websocket
-                self._connected_to_platform_websocket.set_result(True)  # noqa: FBT003
+                self._connected_to_platform_websocket.set_result(True)
                 async for message in websocket:
                     try:
                         parsed_message = json.loads(message)
@@ -234,4 +234,4 @@ async def _process_platform_messages(self: EventManager) -> None:
                         logger.exception('Cannot parse actor event', extra={'message': message})
         except Exception:
             logger.exception('Error in websocket connection')
-            self._connected_to_platform_websocket.set_result(False)  # noqa: FBT003
+            self._connected_to_platform_websocket.set_result(False)

src/apify/log.py

@@ -82,7 +82,7 @@ def _get_extra_fields(self: ActorLogFormatter, record: logging.LogRecord) -> dic
         return extra_fields
 
     @ignore_docs
-    def format(self: ActorLogFormatter, record: logging.LogRecord) -> str:  # noqa: A003
+    def format(self: ActorLogFormatter, record: logging.LogRecord) -> str:
         """Format the log record nicely.
 
         This formats the log record so that it:

src/apify/scrapy/scheduler.py

@@ -35,7 +35,7 @@ def __init__(self: ApifyScheduler) -> None:
         self._rq: RequestQueue | None = None
         self.spider: Spider | None = None
 
-    def open(self: ApifyScheduler, spider: Spider) -> None:  # noqa: A003 # this has to be named "open"
+    def open(self: ApifyScheduler, spider: Spider) -> None:  # this has to be named "open"
         """Open the scheduler.
 
         Args: