Skip to content

Commit b19ea8c

Browse files
committed
Review comments
1 parent 0de39ad commit b19ea8c

File tree

5 files changed

+17
-10
lines changed

5 files changed

+17
-10
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ keywords = [
3636
dependencies = [
3737
"apify-client>=2.0.0,<3.0.0",
3838
"apify-shared>=2.0.0,<3.0.0",
39-
"crawlee @ git+https://github.com/apify/crawlee-python.git@master",
39+
"crawlee==0.6.13b42",
4040
"cachetools>=5.5.0",
4141
"cryptography>=42.0.0",
4242
"impit>=0.6.1",

src/apify/_actor.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ async def init(self) -> None:
341341
await self.event_manager.__aenter__()
342342
self.log.debug('Event manager initialized')
343343

344-
await self.charging_manager_implementation.__aenter__()
344+
await self._charging_manager_implementation.__aenter__()
345345
self.log.debug('Charging manager initialized')
346346

347347
self._is_initialized = True
@@ -385,7 +385,7 @@ async def finalize() -> None:
385385
await self.event_manager.wait_for_all_listeners_to_complete(timeout=event_listeners_timeout)
386386

387387
await self.event_manager.__aexit__(None, None, None)
388-
await self.charging_manager_implementation.__aexit__(None, None, None)
388+
await self._charging_manager_implementation.__aexit__(None, None, None)
389389

390390
await asyncio.wait_for(finalize(), cleanup_timeout.total_seconds())
391391
self._is_initialized = False
@@ -666,10 +666,10 @@ async def set_value(
666666
def get_charging_manager(self) -> ChargingManager:
667667
"""Retrieve the charging manager to access granular pricing information."""
668668
self._raise_if_not_initialized()
669-
return self.charging_manager_implementation
669+
return self._charging_manager_implementation
670670

671671
@cached_property
672-
def charging_manager_implementation(self) -> ChargingManagerImplementation:
672+
def _charging_manager_implementation(self) -> ChargingManagerImplementation:
673673
return ChargingManagerImplementation(self.configuration, self.apify_client)
674674

675675
async def charge(self, event_name: str, count: int = 1) -> ChargeResult:

src/apify/storage_clients/_file_system/_storage_client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,10 @@ async def create_kvs_client(
3232
) -> FileSystemKeyValueStoreClient:
3333
configuration = configuration or Configuration.get_global_configuration()
3434
client = await ApifyFileSystemKeyValueStoreClient.open(
35-
id=id, name=name, alias=alias, configuration=configuration
35+
id=id,
36+
name=name,
37+
alias=alias,
38+
configuration=configuration,
3639
)
3740
await self._purge_if_needed(client, configuration)
3841
return client
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
# The test fixture will put the Apify SDK wheel path on the next line
22
APIFY_SDK_WHEEL_PLACEHOLDER
33
uvicorn[standard]
4-
crawlee[parsel] @ git+https://github.com/apify/crawlee-python.git@master
4+
crawlee[parsel]==0.6.13b42

uv.lock

Lines changed: 7 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)