unit - scrapy middleware apify proxy

Author: vdusek

tests/unit/scrapy/middlewares/test_apify_proxy.py

@@ -60,8 +60,17 @@ def proxy_configuration() -> ProxyConfiguration:
         ({'APIFY_PROXY_SETTINGS': {'useApifyProxy': None}}, NotConfigured),
         ({'APIFY_PROXY_SETTINGS': {'useApifyProxy': False}}, NotConfigured),
     ],
+    ids=[
+        'valid_proxy_settings_enabled',
+        'valid_proxy_settings_with_groups',
+        'no_settings',
+        'irrelevant_setting',
+        'empty_proxy_settings',
+        'use_apify_proxy_none',
+        'use_apify_proxy_false',
+    ],
 )
-def test__from_crawler(
+def test_middleware_initialization_from_crawler(
     crawler: Crawler,
     monkeypatch: pytest.MonkeyPatch,
     settings: dict,
@@ -81,8 +90,9 @@ def test__from_crawler(
 @pytest.mark.parametrize(
     'expected_proxy_url',
     ['http://username:[email protected]:8080', 'http://hsdfgds:[email protected]:5748'],
+    ids=['example_proxy', 'apify_proxy'],
 )
-async def test__get_new_proxy_url(
+async def test_middleware_retrieves_new_proxy_url(
     monkeypatch: pytest.MonkeyPatch,
     middleware: ApifyHttpProxyMiddleware,
     proxy_configuration: ProxyConfiguration,
@@ -104,8 +114,9 @@ async def mock_new_url() -> str:
         ('http://user123:[email protected]:5748', None, b'Basic dXNlcjEyMzpwYXNzNDU2'),
         ('http://@proxy.example.com:2943', ValueError, b''),
     ],
+    ids=['valid_example_proxy', 'valid_apify_proxy', 'invalid_proxy_missing_credentials'],
 )
-async def test__process_request(
+async def test_middleware_process_request_with_proxy(
     monkeypatch: pytest.MonkeyPatch,
     middleware: ApifyHttpProxyMiddleware,
     spider: DummySpider,
@@ -131,8 +142,9 @@ async def mock_get_new_proxy_url() -> ParseResult:
 @pytest.mark.parametrize(
     'exception',
     [TunnelError(), ValueError()],
+    ids=['tunnel_error', 'value_error'],
 )
-def test__process_exception(
+def test_middleware_handles_exceptions(
     middleware: ApifyHttpProxyMiddleware,
     spider: DummySpider,
     dummy_request: Request,