Skip to content

Commit f99a9eb

Browse files
committed
polishment
1 parent f1a7fd7 commit f99a9eb

File tree

6 files changed

+16
-12
lines changed

6 files changed

+16
-12
lines changed

docs/02_guides/05_scrapy.mdx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import TabItem from '@theme/TabItem';
1010
import UnderscoreMainExample from '!!raw-loader!./code/scrapy_project/src/__main__.py';
1111
import MainExample from '!!raw-loader!./code/scrapy_project/src/main.py';
1212
import ItemsExample from '!!raw-loader!./code/scrapy_project/src/items.py';
13-
import SpidersExample from '!!raw-loader!./code/scrapy_project/src/spiders.py';
13+
import SpidersExample from '!!raw-loader!./code/scrapy_project/src/spiders/title.py';
1414
import SettingsExample from '!!raw-loader!./code/scrapy_project/src/settings.py';
1515

1616
[Scrapy](https://scrapy.org/) is an open-source web scraping framework for Python. It provides tools for defining scrapers, extracting data from web pages, following links, and handling pagination. With the Apify SDK, Scrapy projects can be converted into Apify [Actors](https://docs.apify.com/platform/actors), integrated with Apify [storages](https://docs.apify.com/platform/storage), and executed on the Apify [platform](https://docs.apify.com/platform).
@@ -75,19 +75,19 @@ The following example demonstrates a Scrapy Actor that scrapes page titles and e
7575
{MainExample}
7676
</CodeBlock>
7777
</TabItem>
78-
<TabItem value="items.py" label="items.py">
78+
<TabItem value="settings.py" label="settings.py">
7979
<CodeBlock className="language-python">
80-
{ItemsExample}
80+
{SettingsExample}
8181
</CodeBlock>
8282
</TabItem>
83-
<TabItem value="spiders.py" label="spiders.py">
83+
<TabItem value="items.py" label="items.py">
8484
<CodeBlock className="language-python">
85-
{SpidersExample}
85+
{ItemsExample}
8686
</CodeBlock>
8787
</TabItem>
88-
<TabItem value="settings.py" label="settings.py">
88+
<TabItem value="spiders/title.py" label="spiders/title.py">
8989
<CodeBlock className="language-python">
90-
{SettingsExample}
90+
{SpidersExample}
9191
</CodeBlock>
9292
</TabItem>
9393
</Tabs>
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
from .title import TitleSpider

docs/02_guides/code/scrapy_project/src/spiders/py.typed

Whitespace-only changes.

docs/02_guides/code/scrapy_project/src/spiders.py renamed to docs/02_guides/code/scrapy_project/src/spiders/title.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
from scrapy import Request, Spider
77

8-
from .items import TitleItem
8+
from ..items import TitleItem
99

1010
if TYPE_CHECKING:
1111
from collections.abc import Generator

pyproject.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,8 @@ indent-style = "space"
145145
"I001", # Import block is un-sorted or un-formatted
146146
# Class variables are common in Scrapy projects.
147147
"RUF012", # Mutable class attributes should be annotated with `typing.ClassVar`
148+
# Local imports in Scrapy project.
149+
"TID252", # Prefer absolute imports over relative imports from parent modules
148150
]
149151

150152
[tool.ruff.lint.flake8-quotes]

tests/integration/test_actor_scrapy.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,13 @@ async def test_actor_scrapy_title_spider(
1313
run_actor: RunActorFunction,
1414
) -> None:
1515
actor_source_files = {
16-
'src/spiders.py': read_file('docs/02_guides/code/scrapy_project/src/spiders.py'),
17-
'src/items.py': read_file('docs/02_guides/code/scrapy_project/src/items.py'),
18-
'src/settings.py': read_file('docs/02_guides/code/scrapy_project/src/settings.py'),
1916
'src/__init__.py': read_file('docs/02_guides/code/scrapy_project/src/__init__.py'),
20-
'src/main.py': read_file('docs/02_guides/code/scrapy_project/src/main.py'),
2117
'src/__main__.py': read_file('docs/02_guides/code/scrapy_project/src/__main__.py'),
18+
'src/items.py': read_file('docs/02_guides/code/scrapy_project/src/items.py'),
19+
'src/main.py': read_file('docs/02_guides/code/scrapy_project/src/main.py'),
20+
'src/settings.py': read_file('docs/02_guides/code/scrapy_project/src/settings.py'),
21+
'src/spiders/__init__.py': read_file('docs/02_guides/code/scrapy_project/src/spiders/__init__.py'),
22+
'src/spiders/title.py': read_file('docs/02_guides/code/scrapy_project/src/spiders/title.py'),
2223
}
2324

2425
actor = await make_actor('actor-scrapy-title-spider', source_files=actor_source_files)

0 commit comments

Comments
 (0)