Skip to content

fix: Also load input from a file with a .json extension in file system storage #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

fix: Also load input from a file with a .json extension in file system storage #617

wants to merge 10 commits into from
+86 −29

Conversation

janbuchar
Copy link
Contributor

@janbuchar janbuchar requested a review from vdusek October 6, 2025 21:01
@github-actions github-actions bot added this to the 125th sprint - Tooling team milestone Oct 6, 2025
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Oct 6, 2025
@janbuchar janbuchar added the adhoc Ad-hoc unplanned task added during the sprint. label Oct 6, 2025
vdusek
vdusek approved these changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just wondering whether not to use the default value INPUT.json (with extension), instead of INPUT. https://github.com/apify/apify-sdk-python/blob/master/src/apify/_configuration.py#L198

@janbuchar janbuchar requested a review from vdusek October 7, 2025 07:49
@janbuchar janbuchar marked this pull request as ready for review October 7, 2025 07:49
vdusek
vdusek approved these changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

Assignees

@janbuchar janbuchar

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
125th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@janbuchar @vdusek