Skip to content

Commit 1e1bc9c

Browse files
committed
address CR
1 parent f5cc76f commit 1e1bc9c

File tree

4 files changed

+3
-4
lines changed

4 files changed

+3
-4
lines changed

packages/input_schema/src/input_schema.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ function validateField(validator: Ajv, fieldSchema: Record<string, unknown>, fie
270270
if ('propertyNames' in fieldSchema && fieldSchema.propertyNames?.pattern) {
271271
validateRegexpPattern(fieldSchema.propertyNames.pattern, `${fieldKey}.propertyNames.pattern`);
272272
}
273-
if ('patternProperties' in fieldSchema && fieldSchema.patternProperties?.['.*'].pattern) {
273+
if ('patternProperties' in fieldSchema && fieldSchema.patternProperties?.['.*']?.pattern) {
274274
validateRegexpPattern(fieldSchema.patternProperties['.*'].pattern, `${fieldKey}.patternProperties.*.pattern`);
275275
}
276276
}

packages/input_schema/src/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export type ObjectFieldDefinition = CommonFieldDefinition<object> & {
5757
required?: string[];
5858
additionalProperties?: boolean;
5959
propertyNames?: { pattern: string };
60-
patternProperties?: { '.*': { type: 'string', pattern: string } };
60+
patternProperties?: { '.*': { type: 'string'; pattern: string; } };
6161
}
6262

6363
export type ArrayFieldDefinition = CommonFieldDefinition<unknown[]> & {

test/input_schema.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1567,7 +1567,7 @@ describe('input_schema.json', () => {
15671567
patternProperties: {
15681568
'^[a-zA-Z_][a-zA-Z0-9_]*$': {
15691569
type: 'string',
1570-
regex: '^[0-9]+$',
1570+
pattern: '^[0-9]+$',
15711571
},
15721572
},
15731573
},

test/utilities.client.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1787,7 +1787,6 @@ describe('utilities.client', () => {
17871787
type: 'object',
17881788
editor: 'schemaBased',
17891789
propertyNames: {
1790-
type: 'string',
17911790
pattern: '^key_\\d+$',
17921791
},
17931792
},

0 commit comments

Comments
 (0)