refactor: changed to bigint to avoid overflow

Author: danpoletaev

packages/utilities/src/hmac.ts

@@ -3,18 +3,18 @@ import crypto from 'crypto';
 const CHARSET = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ'.split('');
 
 /**
- * Encodes number to base62.
+ * Encodes BigInt to base62.
  * To avoid new dependency, this function was copied from https://github.com/base62/base62.js/blob/master/lib/ascii.js
  */
-function encodeBase62(num: number) {
-    if (num === 0) {
+function encodeBase62(num: bigint) {
+    if (num === 0n) {
         return CHARSET[0];
     }
 
     let res = '';
-    while (num > 0) {
-        res = CHARSET[num % 62] + res;
-        num = Math.floor(num / 62);
+    while (num > 0n) {
+        res = CHARSET[Number(num % 62n)] + res;
+        num /= 62n;
     }
     return res;
 }
@@ -33,5 +33,5 @@ export function createHmacSignature(secretKey: string, message: string): string
         .digest('hex')
         .substring(0, 30);
 
-    return encodeBase62(parseInt(signature, 16));
+    return encodeBase62(BigInt(`0x${signature}`));
 }

test/hmac.test.ts

@@ -4,14 +4,14 @@ describe('createHmacSignature()', () => {
     it('should create a valid HMAC signature', () => {
         const secretKey = 'hmac-secret-key';
         const message = 'hmac-message-to-be-authenticated';
-        expect(createHmacSignature(secretKey, message)).toBe('pcVagAsud2gqKY2qCy2G');
+        expect(createHmacSignature(secretKey, message)).toBe('pcVagAsudj8dFqdlg7mG');
     });
 
     it('should create same HMAC signature, when secretKey and message are same', () => {
         const secretKey = 'hmac-same-secret-key';
         const message = 'hmac-same-message-to-be-authenticated';
         for (let i = 0; i < 5; i++) {
-            expect(createHmacSignature(secretKey, message)).toBe('FYMcmTIm2sQ68EcG8yyQ');
+            expect(createHmacSignature(secretKey, message)).toBe('FYMcmTIm3idXqleF1Sw5');
         }
     });
 });