fix(consts): refine Profile name and username regexes

Author: DaveHanns

packages/consts/src/consts.ts

@@ -116,7 +116,7 @@ export const USERNAME = {
 
     // Regex matching a potentially allowed username. The numbers must match MIN and MAX!
     // Note that username must also pass isForbiddenUser() test to be allowed!
-    REGEX: /^[a-zA-Z0-9_-]{3,30}$/,
+    REGEX: /^[a-zA-Z0-9_.-]{3,30}$/,
 };
 
 export const EMAIL = {
@@ -133,8 +133,8 @@ export const PROFILE_NAME = {
     MIN_LENGTH: 3,
     MAX_LENGTH: 50,
 
-    // Regex to prohibit anything that could potentially form an URL or email address.
-    REGEX: /^[^/.@><]*$/,
+    // Prohibits usage of @, <, > and :// in the name
+    REGEX: /^(?!.*:\/\/)[^@><]*$/,
 };
 
 /**

test/consts.test.ts

@@ -1,19 +1,56 @@
-import { USERNAME, APIFY_ID_REGEX, ACTOR_ENV_VARS, ENV_VARS, APIFY_ENV_VARS, LOCAL_ACTOR_ENV_VARS, LOCAL_APIFY_ENV_VARS, LOCAL_ENV_VARS } from '@apify/consts';
+import {
+    USERNAME,
+    APIFY_ID_REGEX,
+    ACTOR_ENV_VARS,
+    ENV_VARS,
+    APIFY_ENV_VARS,
+    LOCAL_ACTOR_ENV_VARS,
+    LOCAL_APIFY_ENV_VARS,
+    LOCAL_ENV_VARS,
+    PROFILE_NAME,
+} from '@apify/consts';
 import { cryptoRandomObjectId } from '@apify/utilities';
 
 describe('consts', () => {
     describe('USERNAME', () => {
         it('REGEX works as expected', () => {
             expect(USERNAME.REGEX.test('anonymous')).toBe(true);
             expect(USERNAME.REGEX.test('---')).toBe(true);
+            expect(USERNAME.REGEX.test('john.doe')).toBe(true);
             expect(USERNAME.REGEX.test('john')).toBe(true);
             expect(USERNAME.REGEX.test('john-doe')).toBe(true);
             expect(USERNAME.REGEX.test('JOHN_doe')).toBe(true);
+            expect(USERNAME.REGEX.test('favicon.icox')).toBe(true);
+            expect(USERNAME.REGEX.test('xfavicon.ico')).toBe(true);
             expect(USERNAME.REGEX.test('karl12345')).toBe(true);
             expect(USERNAME.REGEX.test('45678')).toBe(true);
         });
     });
 
+    describe('PROFILE_NAME', () => {
+        it('REGEX works as expected', () => {
+            // Valid cases
+            expect(PROFILE_NAME.REGEX.test('John Doe')).toBe(true);
+            expect(PROFILE_NAME.REGEX.test('Anonymous')).toBe(true);
+            expect(PROFILE_NAME.REGEX.test('John123')).toBe(true);
+            expect(PROFILE_NAME.REGEX.test('John-Doe')).toBe(true);
+            expect(PROFILE_NAME.REGEX.test('Org_Example')).toBe(true);
+            expect(PROFILE_NAME.REGEX.test(':/JohnDoe')).toBe(true);
+            expect(PROFILE_NAME.REGEX.test(':/a/Simple.Name')).toBe(true);
+            expect(PROFILE_NAME.REGEX.test('John:/Doe/')).toBe(true);
+            expect(PROFILE_NAME.REGEX.test('Simple:.//Name')).toBe(true);
+            expect(PROFILE_NAME.REGEX.test('Joh////:/n-Doe')).toBe(true);
+            expect(PROFILE_NAME.REGEX.test('user:name')).toBe(true);
+
+            // Invalid cases
+            expect(PROFILE_NAME.REGEX.test('user@name')).toBe(false);
+            expect(PROFILE_NAME.REGEX.test('user>name')).toBe(false);
+            expect(PROFILE_NAME.REGEX.test('user<name')).toBe(false);
+            expect(PROFILE_NAME.REGEX.test('example://test')).toBe(false);
+            expect(PROFILE_NAME.REGEX.test('example://////test')).toBe(false);
+        });
+    });
+
     describe('APIFY_ID_REGEX', () => {
         it('matches testing apify IDs', () => {
             const testingStrings = {