Skip to content

Conversation

tobice
Copy link
Contributor

@tobice tobice commented Sep 4, 2025

This enum is required for the Python client so that it supports the new forcePermissionLevel run option.

Full context here: https://github.com/apify/apify-core/pull/22681

@tobice tobice requested review from vdusek and stepskop September 4, 2025 14:58
@tobice tobice self-assigned this Sep 4, 2025
@github-actions github-actions bot added the t-core-services Issues with this label are in the ownership of the core services team. label Sep 4, 2025
@tobice
Copy link
Contributor Author

tobice commented Sep 4, 2025

Not sure why uv.lock was added 🤔 Without it, I wasn't able to commit without it 🤔

Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please use standard docstrings instead of comments? Thanks.

Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and also please undo all the upload-time/upload_time changes. You have an old version of uv. More context here -> astral-sh/uv#13176.

@tobice
Copy link
Contributor Author

tobice commented Sep 5, 2025

Used the standard docstrings.... it's super weird to have them below the name 😄

Also updated uv and reverted the uv.lock change... but it still changes the version 🤔 It now corresponds to the version in pyproject.toml which sounds legit but then I'm not sure why it hasn't been changed already.

@tobice tobice requested a review from vdusek September 5, 2025 11:12
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobice tobice merged commit 52a1f73 into master Sep 5, 2025
18 checks passed
@tobice tobice deleted the tobik/feat/add-actor-permission-level-enum branch September 5, 2025 12:37
@tobice tobice added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-core-services Issues with this label are in the ownership of the core services team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants