Skip to content

Commit 33b0372

Browse files
committed
mypy is broken - add type ignore
1 parent 76cb42f commit 33b0372

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

src/crawlee/storages/_dataset.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ async def push_data(self, data: JsonSerializable, **kwargs: Unpack[PushDataKwarg
241241
# Handle singular items
242242
if not isinstance(data, list):
243243
items = await self.check_and_serialize(data)
244-
return await self._resource_client.push_items(items, **kwargs)
244+
return await self._resource_client.push_items(items, **kwargs) # type: ignore[no-any-return] # Mypy is broken
245245

246246
# Handle lists
247247
payloads_generator = (await self.check_and_serialize(item, index) for index, item in enumerate(data))
@@ -264,7 +264,7 @@ async def get_data(self, **kwargs: Unpack[GetDataKwargs]) -> DatasetItemsListPag
264264
Returns:
265265
List page containing filtered and paginated dataset items.
266266
"""
267-
return await self._resource_client.list_items(**kwargs)
267+
return await self._resource_client.list_items(**kwargs) # type: ignore[no-any-return] # Mypy is broken
268268

269269
async def write_to_csv(self, destination: TextIO, **kwargs: Unpack[ExportDataCsvKwargs]) -> None:
270270
"""Exports the entire dataset into an arbitrary stream.

src/crawlee/storages/_key_value_store.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ def name(self) -> str | None:
7272

7373
async def get_info(self) -> KeyValueStoreMetadata | None:
7474
"""Get an object containing general information about the key value store."""
75-
return await self._resource_client.get()
75+
return await self._resource_client.get() # type: ignore[no-any-return] # Mypy is broken
7676

7777
@override
7878
@classmethod
@@ -142,9 +142,9 @@ async def set_value(
142142
content_type: Content type of the record.
143143
"""
144144
if value is None:
145-
return await self._resource_client.delete_record(key)
145+
return await self._resource_client.delete_record(key) # type: ignore[no-any-return] # Mypy is broken
146146

147-
return await self._resource_client.set_record(key, value, content_type)
147+
return await self._resource_client.set_record(key, value, content_type) # type: ignore[no-any-return] # Mypy is broken
148148

149149
async def get_public_url(self, key: str) -> str:
150150
"""Get the public URL for the given key.
@@ -155,4 +155,4 @@ async def get_public_url(self, key: str) -> str:
155155
Returns:
156156
The public URL for the given key.
157157
"""
158-
return await self._resource_client.get_public_url(key)
158+
return await self._resource_client.get_public_url(key) # type: ignore[no-any-return] # Mypy is broken

src/crawlee/storages/_request_queue.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ async def add_request(
204204
):
205205
self._assumed_total_count += 1
206206

207-
return processed_request
207+
return processed_request # type: ignore[no-any-return] # Mypy is broken
208208

209209
@override
210210
async def add_requests_batched(
@@ -260,7 +260,7 @@ async def get_request(self, request_id: str) -> Request | None:
260260
Returns:
261261
The retrieved request, or `None`, if it does not exist.
262262
"""
263-
return await self._resource_client.get_request(request_id)
263+
return await self._resource_client.get_request(request_id) # type: ignore[no-any-return] # Mypy is broken
264264

265265
async def fetch_next_request(self) -> Request | None:
266266
"""Return the next request in the queue to be processed.
@@ -373,7 +373,7 @@ async def mark_request_as_handled(self, request: Request) -> ProcessedRequest |
373373
self._assumed_handled_count += 1
374374

375375
self._cache_request(unique_key_to_request_id(request.unique_key), processed_request)
376-
return processed_request
376+
return processed_request # type: ignore[no-any-return] # Mypy is broken
377377

378378
async def reclaim_request(
379379
self,
@@ -417,7 +417,7 @@ async def reclaim_request(
417417
except Exception as err:
418418
logger.debug(f'Failed to delete request lock for request {request.id}', exc_info=err)
419419

420-
return processed_request
420+
return processed_request # type: ignore[no-any-return] # Mypy is broken
421421

422422
async def is_empty(self) -> bool:
423423
"""Check whether the queue is empty.
@@ -483,7 +483,7 @@ async def is_finished(self) -> bool:
483483

484484
async def get_info(self) -> RequestQueueMetadata | None:
485485
"""Get an object containing general information about the request queue."""
486-
return await self._resource_client.get()
486+
return await self._resource_client.get() # type: ignore[no-any-return] # Mypy is broken
487487

488488
@override
489489
async def get_handled_count(self) -> int:
@@ -658,7 +658,7 @@ async def _prolong_request_lock(self, request_id: str) -> datetime | None:
658658
)
659659
return None
660660
else:
661-
return res.lock_expires_at
661+
return res.lock_expires_at # type: ignore[no-any-return] # Mypy is broken
662662

663663
async def _clear_possible_locks(self) -> None:
664664
self._queue_paused_for_migration = True

0 commit comments

Comments
 (0)